[PATCH v2 2/3] dma/ae4dma: add control path operations

Raghavendra Ningoji raghavendra.ningoji at amd.com
Thu Jun 25 20:42:56 CEST 2026


On Mon, 22 Jun 2026 at 14:15, David Marchand <david.marchand at redhat.com> wrote:
>
> > +       info->dev_name = dev->device->name;
>
> The dmadev library sets this field in rte_dma_info_get().
> Please remove.

Removed.

> > +               const struct rte_memzone *mz = rte_memzone_lookup(cmd_q->memz_name);
>
> Rather than resolve again, can't you store the reference to the
> memzone in the priv pointer at probe time?

Done. The memzone reference is stored in cmd_q->mz at probe time (in
patch 1/3) and dev_close() now frees cmd_q->mz directly without a
lookup.

> > +               if (mz != NULL)
> > +                       rte_memzone_free(mz);
>
> No need to test for NULL.

Removed; rte_memzone_free(cmd_q->mz) is called unconditionally.

Sent as v3.

Thanks,
Raghavendra


More information about the dev mailing list