[PATCH dpdk v3] net/tap: use offsets provided by rte_net_get_ptype

Stephen Hemminger stephen at networkplumber.org
Sun May 3 05:29:48 CEST 2026


On Fri,  1 May 2026 01:28:07 +0200
Robin Jarry <rjarry at redhat.com> wrote:

> Instead of guessing what are the proper header lengths, pass
> a rte_net_hdr_lens struct to rte_net_get_ptype and use it to get the
> proper header lengths/offsets in tap_verify_csum.
> 
> This allows supporting stacked VLAN/QinQ tags and IPv6 extensions.
> 
> Signed-off-by: Robin Jarry <rjarry at redhat.com>
> ---

LGTM, AI found a couple of small things.

Info: stale comment
In the same else branch, the comment is now inaccurate since l3 can
also be RTE_PTYPE_L3_IPV6_EXT:
} else { /* l3 == RTE_PTYPE_L3_IPV6, checked above */

Info: cover letter
The "supporting [...] IPv6 extensions" claim should be qualified or
removed depending on which fix is taken. The header-length and offset
math is now extension-aware, but L4 checksum validation is not.


More information about the dev mailing list