[PATCH v12 2/5] vhost_user: header defines for add/rem mem region

[Bathija, Pravin]

Hi Fengcheng,

Responses inline. I have made the suggested changes and submitted version 13 of the patch-set. Please review.


Internal Use - Confidential
> -----Original Message-----
> From: fengchengwen <fengchengwen at huawei.com>
> Sent: Tuesday, May 12, 2026 7:30 PM
> To: Bathija, Pravin <Pravin.Bathija at dell.com>; dev at dpdk.org;
> stephen at networkplumber.org; maxime.coquelin at redhat.com
> Cc: thomas at monjalon.net
> Subject: Re: [PATCH v12 2/5] vhost_user: header defines for add/rem mem
> region
>
>
> [EXTERNAL EMAIL]
>
> On 5/6/2026 11:37 AM, pravin.bathija at dell.com wrote:
> > From: Pravin M Bathija <pravin.bathija at dell.com>
> >
> > The changes in this file cover the enum message requests for
> > supporting add/remove memory regions. The front-end vhost-user client
> > sends messages like get max memory slots, add memory region and remove
> > memory region which are covered in these changes which are on the
> > vhost-user back-end. The changes also include data structure
> > definition of memory region to be added/removed. The data structure
> > VhostUserMsg has been changed to include the memory region.
> >
> > Signed-off-by: Pravin M Bathija <pravin.bathija at dell.com>
> > ---
> >  lib/vhost/vhost_user.h | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> >
> > diff --git a/lib/vhost/vhost_user.h b/lib/vhost/vhost_user.h index
> > ef486545ba..f8d921f7f1 100644
> > --- a/lib/vhost/vhost_user.h
> > +++ b/lib/vhost/vhost_user.h
> > @@ -67,6 +67,9 @@ typedef enum VhostUserRequest {
> >     VHOST_USER_POSTCOPY_END = 30,
> >     VHOST_USER_GET_INFLIGHT_FD = 31,
> >     VHOST_USER_SET_INFLIGHT_FD = 32,
> > +   VHOST_USER_GET_MAX_MEM_SLOTS = 36,
> > +   VHOST_USER_ADD_MEM_REG = 37,
> > +   VHOST_USER_REM_MEM_REG = 38,
> >     VHOST_USER_SET_STATUS = 39,
> >     VHOST_USER_GET_STATUS = 40,
> >  } VhostUserRequest;
> > @@ -91,6 +94,11 @@ typedef struct VhostUserMemory {
> >     VhostUserMemoryRegion
> regions[VHOST_MEMORY_MAX_NREGIONS];
> >  } VhostUserMemory;
> >
> > +typedef struct VhostUserSingleMemReg {
> > +   uint64_t padding;
> > +   VhostUserMemoryRegion region;
> > +} VhostUserSingleMemReg;
>
> How about the same as qemu vhost define: VhostUserMemRegMsg

Sure. Made the change as suggested.
>
> > +
> >  typedef struct VhostUserLog {
> >     uint64_t mmap_size;
> >     uint64_t mmap_offset;
> > @@ -186,6 +194,7 @@ typedef struct __rte_packed_begin VhostUserMsg {
> >             struct vhost_vring_state state;
> >             struct vhost_vring_addr addr;
> >             VhostUserMemory memory;
> > +           VhostUserSingleMemReg memory_single;
>
> Suggest the same as qemu define: VhostUserMemRegMsg memreg;

Sure. Made the change as suggested.

>
> >             VhostUserLog    log;
> >             struct vhost_iotlb_msg iotlb;
> >             VhostUserCryptoSessionParam crypto_session;
>
> With above fix
> Acked-by: Chengwen Feng <fengchengwen at huawei.com>