[PATCH v14 3/6] devtools: add compare-reviews.sh for multi-provider analysis

Thomas Monjalon thomas at monjalon.net
Thu May 21 16:17:44 CEST 2026


14/04/2026 23:08, Stephen Hemminger:
> +#!/bin/bash

I'm not sure why bash is required for this script.
It could be just /bin/sh.

[...]
> +    [[ -n "$ANTHROPIC_API_KEY" ]] && available="${available}anthropic,"

If you replace double brackets with single ones,
you should be close to a POSIX shell script.

> +            [[ -z "${2:-}" || "$2" == -* ]] && error "$1 requires an argument"

and replace == with simple = in tests.




More information about the dev mailing list