回复: [V1 1/1] net/hinic3: Add VXLAN TSO function

[wangfeifei (J)]

> -----邮件原件-----
> 发件人: Stephen Hemminger <stephen at networkplumber.org>
> 发送时间: 2026年5月20日 23:07
> 收件人: Feifei Wang <wff_light at vip.163.com>
> 抄送: dev at dpdk.org; wangfeifei (J) <wangfeifei40 at huawei.com>
> 主题: Re: [V1 1/1] net/hinic3: Add VXLAN TSO function
> 
> On Wed, 20 May 2026 14:58:15 +0800
> Feifei Wang <wff_light at vip.163.com> wrote:
> 
> > The RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO flag is added to support the
> > VXLAN TSO function
> >
> > Signed-off-by: Feifei Wang <wangfeifei40 at huawei.com>
> > ---
> 
> You need to do more than just advertise the capability to get the driver to
> actually work right.
> 
> AI explanation:
> 
> Error: VXLAN TSO is advertised unconditionally but the underlying hardware
> feature is not. The patch adds RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO to the
> unconditional tx_offload_capa assignment in hinic3_dev_infos_get(), but the Tx
> path in drivers/net/hinic3/hinic3_tx.c:306-313 rejects every VXLAN tunnel mbuf
> when the hardware does not have NIC_F_VXLAN_OFFLOAD:
[Feifei] Thanks for your reviewing. Above comment is valuable, we ignore this.
In the next version, we will change as below:

if (HINIC3_SUPPORT_VXLAN_OFFLOAD(nic_dev))
	info->tx_offload_capa |= RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO