[PATCH v4 04/20] net/ngbe: fix VF promiscuous and allmulticast

[Zaiyu Wang]

> -----Original Message-----
> From: Stephen Hemminger <stephen at networkplumber.org>
> Sent: Monday, May 18, 2026 7:39 AM
> To: Zaiyu Wang <zaiyuwang at trustnetic.com>; Zaiyu Wang
> <zaiyuwang at trustnetic.com>
> Cc: dev at dpdk.org; stable at dpdk.org; Jiawen Wu <jiawenwu at trustnetic.com>;
> dev at dpdk.org; stable at dpdk.org; Jiawen Wu <jiawenwu at trustnetic.com>
> Subject: Re: [PATCH v4 04/20] net/ngbe: fix VF promiscuous and allmulticast
> 
> On Mon, 11 May 2026 18:35:46 +0800
> Zaiyu Wang <zaiyuwang at trustnetic.com> wrote:
> 
> > The configuration of allmulti and promiscuous modes conflicts
> > together. For instance, if we enable promiscuous mode, then enable and
> > disable allmulti, then the promiscuous mode is wrongly disabled.
> >
> > To resolve this, the following changes are made:
> > - do nothing when we set/unset allmulti if promiscuous mode is on
> > - restore the proper mode (none or allmulti) when we disable
> >   promiscuous mode
> >
> > Fixes: 7744e90805b5 ("net/ngbe: add promiscuous and allmulticast ops
> > for VF device")
> > Cc: stable at dpdk.org
> >
> > Signed-off-by: Zaiyu Wang <zaiyuwang at trustnetic.com>
> > ---
> 
> Worth mentioning, but IMHO this is case of AI being overly pedantic.
> Patch is OK as is.
Thanks.