[PATCH 3/3] net/bonding: remove redundant function names from log

Bruce Richardson bruce.richardson at intel.com
Wed May 27 18:28:06 CEST 2026


On Fri, Apr 17, 2026 at 09:51:37AM -0700, Stephen Hemminger wrote:
> The function name is already printed as part of RTE_BOND_LOG().
> 
> Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
> ---

Acked-by: Bruce Richardson <bruce.richardson at intel.com>

>  drivers/net/bonding/rte_eth_bond_api.c |  4 ++--
>  drivers/net/bonding/rte_eth_bond_pmd.c | 23 ++++++++++-------------
>  2 files changed, 12 insertions(+), 15 deletions(-)
> 
> diff --git a/drivers/net/bonding/rte_eth_bond_api.c b/drivers/net/bonding/rte_eth_bond_api.c
> index 9e5df67c18..78361e73d4 100644
> --- a/drivers/net/bonding/rte_eth_bond_api.c
> +++ b/drivers/net/bonding/rte_eth_bond_api.c
> @@ -485,8 +485,8 @@ __eth_bond_member_add_lock_free(uint16_t bonding_port_id, uint16_t member_port_i
>  	ret = rte_eth_dev_info_get(member_port_id, &dev_info);
>  	if (ret != 0) {
>  		RTE_BOND_LOG(ERR,
> -			"%s: Error during getting device (port %u) info: %s",
> -			__func__, member_port_id, strerror(-ret));
> +			"Error during getting device (port %u) info: %s",

While updating, I think it would be good to update the log messages to be
more natural-sounding English. s/during getting/getting/

> +			member_port_id, strerror(-ret));
>  
>  		return ret;
>  	}
> diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c
> index 6a42257d2b..e2819c931b 100644
> --- a/drivers/net/bonding/rte_eth_bond_pmd.c
> +++ b/drivers/net/bonding/rte_eth_bond_pmd.c
> @@ -210,8 +210,8 @@ bond_ethdev_8023ad_flow_verify(struct rte_eth_dev *bond_dev,
>  	int ret = rte_flow_validate(member_port, &flow_attr_8023ad,
>  			flow_item_8023ad, actions, &error);
>  	if (ret < 0) {
> -		RTE_BOND_LOG(ERR, "%s: %s (member_port=%d queue_id=%d)",
> -				__func__, error.message, member_port,
> +		RTE_BOND_LOG(ERR, "%s (member_port=%u queue_id=%u)",
> +				error.message, member_port,
>  				internals->mode4.dedicated_queues.rx_qid);
>  		return -1;
>  	}
> @@ -219,8 +219,8 @@ bond_ethdev_8023ad_flow_verify(struct rte_eth_dev *bond_dev,
>  	ret = rte_eth_dev_info_get(member_port, &member_info);
>  	if (ret != 0) {
>  		RTE_BOND_LOG(ERR,
> -			"%s: Error during getting device (port %u) info: %s",
> -			__func__, member_port, strerror(-ret));
> +			"Error during getting device (port %u) info: %s",
> +			member_port, strerror(-ret));
>  
>  		return ret;
>  	}
> @@ -228,8 +228,8 @@ bond_ethdev_8023ad_flow_verify(struct rte_eth_dev *bond_dev,
>  	if (member_info.max_rx_queues < bond_dev->data->nb_rx_queues ||
>  			member_info.max_tx_queues < bond_dev->data->nb_tx_queues) {
>  		RTE_BOND_LOG(ERR,
> -			"%s: Member %d capabilities doesn't allow allocating additional queues",
> -			__func__, member_port);
> +			"Member %u capabilities doesn't allow allocating additional queues",
> +			member_port);
>  		return -1;
>  	}
>  
> @@ -249,9 +249,8 @@ bond_8023ad_slow_pkt_hw_filter_supported(uint16_t port_id) {
>  		ret = rte_eth_dev_info_get(bond_dev->data->port_id, &bond_info);
>  		if (ret != 0) {
>  			RTE_BOND_LOG(ERR,
> -				"%s: Error during getting device (port %u) info: %s",
> -				__func__, bond_dev->data->port_id,
> -				strerror(-ret));
> +				"Error during getting device (port %u) info: %s",
> +				bond_dev->data->port_id, strerror(-ret));
>  
>  			return ret;
>  		}
> @@ -2347,10 +2346,8 @@ bond_ethdev_info(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
>  			ret = rte_eth_dev_info_get(member.port_id, &member_info);
>  			if (ret != 0) {
>  				RTE_BOND_LOG(ERR,
> -					"%s: Error during getting device (port %u) info: %s",
> -					__func__,
> -					member.port_id,
> -					strerror(-ret));
> +					"Error during getting device (port %u) info: %s",
> +					member.port_id, strerror(-ret));
>  
>  				return ret;
>  			}


More information about the dev mailing list