[PATCH v2 2/4] net/bonding: check mode before setting dedicated queues

[Stephen Hemminger]

The calls to enable and disable dedicated queues are missing
check for mode.

Fixes: 112891cd27e5 ("net/bonding: add dedicated HW queues for LACP control")
Cc: stable at dpdk.org

Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
---
 drivers/net/bonding/rte_eth_bond_8023ad.c | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c
index eba713e381..d1f30229d0 100644
--- a/drivers/net/bonding/rte_eth_bond_8023ad.c
+++ b/drivers/net/bonding/rte_eth_bond_8023ad.c
@@ -1725,7 +1725,6 @@ RTE_EXPORT_SYMBOL(rte_eth_bond_8023ad_dedicated_queues_enable)
 int
 rte_eth_bond_8023ad_dedicated_queues_enable(uint16_t port)
 {
-	int retval = 0;
 	struct rte_eth_dev *dev;
 	struct bond_dev_private *internals;
 
@@ -1742,17 +1741,19 @@ rte_eth_bond_8023ad_dedicated_queues_enable(uint16_t port)
 	if (dev->data->dev_started)
 		return -1;
 
+	if (internals->mode != BONDING_MODE_8023AD)
+		return -1;
+
 	internals->mode4.dedicated_queues.enabled = 1;
 
 	bond_ethdev_mode_set(dev, internals->mode);
-	return retval;
+	return 0;
 }
 
 RTE_EXPORT_SYMBOL(rte_eth_bond_8023ad_dedicated_queues_disable)
 int
 rte_eth_bond_8023ad_dedicated_queues_disable(uint16_t port)
 {
-	int retval = 0;
 	struct rte_eth_dev *dev;
 	struct bond_dev_private *internals;
 
@@ -1766,9 +1767,12 @@ rte_eth_bond_8023ad_dedicated_queues_disable(uint16_t port)
 	if (dev->data->dev_started)
 		return -1;
 
+	if (internals->mode != BONDING_MODE_8023AD)
+		return -1;
+
 	internals->mode4.dedicated_queues.enabled = 0;
 
 	bond_ethdev_mode_set(dev, internals->mode);
 
-	return retval;
+	return 0;
 }
-- 
2.53.0