[PATCH v3] net/nfp: fix wrong argument order in nfp_encode_basic
Mark Bulatov
ms.bulatov7 at gmail.com
Thu Nov 19 19:19:05 CET 2026
nfp_encode_basic_qdr() takes dest_island as its second argument
and cpp_tgt as its third, but all callers in nfp_encode_basic()
pass them in the opposite order. As a result nfp_decode_basic()
gets the island ID as the target, and the island check compares
against NFP_CPP_TARGET_QDR instead of the requested island.
Fix this by swapping the arguments.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Fixes: e6858e7e7cd3 ("net/nfp: move shared target logic to own file")
Cc: stable at dpdk.org
Signed-off-by: Mark Bulatov <ms.bulatov7 at gmail.com>
---
v3 changes: Correction description
v2 link:
https://patches.dpdk.org/project/dpdk/patch/20261116172037.5347-1-ms.bulatov7@gmail.com/
v2 changes: Correction of the 'Fixes' tag and description
v1 link:
https://patches.dpdk.org/project/dpdk/patch/20261113142823.5918-1-ms.bulatov7@gmail.com/
drivers/net/nfp/nfpcore/nfp_target.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/nfp/nfpcore/nfp_target.c b/drivers/net/nfp/nfpcore/nfp_target.c
index 0e7a5cbb05..239ffff869 100644
--- a/drivers/net/nfp/nfpcore/nfp_target.c
+++ b/drivers/net/nfp/nfpcore/nfp_target.c
@@ -728,7 +728,7 @@ nfp_encode_basic(uint64_t *addr,
* address but we can verify if the existing contents
* will point to a valid island.
*/
- return nfp_encode_basic_qdr(*addr, cpp_tgt, dest_island,
+ return nfp_encode_basic_qdr(*addr, dest_island, cpp_tgt,
mode, addr40, isld1, isld0);
}
@@ -741,7 +741,7 @@ nfp_encode_basic(uint64_t *addr,
return 0;
case 1:
if (cpp_tgt == NFP_CPP_TARGET_QDR && addr40 == 0) {
- return nfp_encode_basic_qdr(*addr, cpp_tgt, dest_island,
+ return nfp_encode_basic_qdr(*addr, dest_island, cpp_tgt,
mode, addr40, isld1, isld0);
}
@@ -763,7 +763,7 @@ nfp_encode_basic(uint64_t *addr,
if (cpp_tgt == NFP_CPP_TARGET_QDR && addr40 == 0) {
/* iid<0> = addr<30> = channel<0> */
/* channel<1> = addr<31> = Index */
- return nfp_encode_basic_qdr(*addr, cpp_tgt, dest_island,
+ return nfp_encode_basic_qdr(*addr, dest_island, cpp_tgt,
mode, addr40, isld1, isld0);
}
@@ -786,7 +786,7 @@ nfp_encode_basic(uint64_t *addr,
* iid<1> = addr<30> = channel<0>
* channel<1> = addr<31> = Index
*/
- return nfp_encode_basic_qdr(*addr, cpp_tgt, dest_island,
+ return nfp_encode_basic_qdr(*addr, dest_island, cpp_tgt,
mode, addr40, isld1, isld0);
}
--
2.39.5
More information about the dev
mailing list