[PATCH] net/ice: fix silent drop of MAC addrs in ACL rules
Bruce Richardson
bruce.richardson at intel.com
Fri Nov 20 11:41:49 CET 2026
On Thu, Nov 19, 2026 at 11:08:39AM +0000, Loftus, Ciara wrote:
> > Subject: [PATCH] net/ice: fix silent drop of MAC addrs in ACL rules
> >
> > For devices with 4 or more ports, the size of the ACL rules supported is
> > narrower, so MAC addresess are not handled there (see [1]). Reject such
>
> Typo: addresses
>
> > rules in the ACL block rather than silently accepting them with missing
> > filter fields. Those rules can then be passed to other engines which may
> > be able to accept and correctly implement them.
> >
> > [1]
> > https://github.com/DPDK/dpdk/blob/main/drivers/net/intel/ice/ice_acl_filter
> > .c#L170
>
> This line reference will be stale once that file is updated on main.
> I don't think the footnote is necessary. If you want to point to something
> you could point to the function name eg. "see acl_add_prof_prepare()"
> If you want to keep a URL, use a SHA that will remain constant.
>
> >
> > Fixes: 40d466fa9f76 ("net/ice: support ACL filter in DCF")
> > Cc: stable at dpdk.org
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson at intel.com>
>
> Code LGTM.
>
> Acked-by: Ciara Loftus <ciara.loftus at intel.com>
>
Applied to dpdk-next-net-intel with suggested commit log change (and
spelling correction on "addresses").
/Bruce
More information about the dev
mailing list