[PATCH v4 02/23] ethdev: use DPDK byte order conversion

Stephen Hemminger stephen at networkplumber.org
Thu Sep 3 18:08:02 CEST 2026


On Thu, 3 Sep 2026 10:20:31 +0100
Bruce Richardson <bruce.richardson at intel.com> wrote:

> On Wed, Aug 05, 2026 at 10:08:56PM -0700, Stephen Hemminger wrote:
> > DPDK has its own byte order macros which are preferred
> > over the POSIX/libc ones in arpa/inet.h
> > This resolves issue where this code was inheriting the
> > inclusion of arpa/inet.h from rte_ethdev.h -> rte_eth_ctrl.h.
> > 
> > Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
> > ---
> >  lib/ethdev/sff_8472.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >   
> 
> Acked-by: Bruce Richardson <bruce.richardson at intel.com>
> 
> Ok fix, though I would note that this fix is nothing to do with the removal
> of flow director material.

What happened was that when flow director part (in rte_eth_ctrl.h)
is removed from always being included by rte_ethdev.h, then this
code would not build.  The code relied on the include cascade:
   rte_ethdev.h
     rte_eth_ctrl.h
       rte_flow.h
         rte_ip4.h
           arpa/inet.h

Maybe other things are getting this as well?
The DPDK IP headers should rely on the Linux definitions, but that
is  a different issue.


More information about the dev mailing list