[PATCH v2] eal/x86: fix memcpy alignment mask definition
Morten Brørup
mb at smartsharesystems.com
Fri Sep 4 13:28:45 CEST 2026
> From: Bruce Richardson [mailto:bruce.richardson at intel.com]
> Sent: Friday, 4 September 2026 13.25
>
> On Fri, Sep 04, 2026 at 11:19:12AM +0000, Morten Brørup wrote:
> > An alignment mask (ALIGNMENT_MASK) is temporarily defined for
> internal
> > purposes, but it is publicly exposed when including the header file,
> > potentially colliding with existing definitions with the same name.
> > Fixed this potential issue by adding the RTE_MEMCPY_ prefix to the
> > definition.
> >
> > Furthermore, the superfluous function declaration at the top of the
> file
> > was removed, and its description was moved to the function
> definition,
> > to improve search results with source code browsers.
> >
> > Also, changed "!(addrs & MASK)" to "(addrs & MASK) == 0" to follow
> DPDK
> > coding style.
> >
> > None of these changes should have any practical effect.
> >
> > Fixes: f5472703c0bd ("eal: optimize aligned memcpy on x86")
> >
> > Signed-off-by: Morten Brørup <mb at smartsharesystems.com>
> Acked-by: Bruce Richardson <bruce.richardson at intel.com>
> > ---
> > v2:
> > * Changed "!(addrs & MASK)" to "(addrs & MASK) == 0". (AI)
>
> Did you miss this change in v2? I still see the "!" below.
Thank you, yes.
It's in my editor, but not on disk. :-\
Will send v3 shortly.
More information about the dev
mailing list