[dts] [PATCH] l3fwd/testpmd performance: optimize command for testpmd and comment some cases no need to run.
Xu, Qian Q
qian.q.xu at intel.com
Fri Apr 22 03:30:16 CEST 2016
See below comments.
From: dts [mailto:dts-bounces at dpdk.org] On Behalf Of Liu, Yong
Sent: Friday, April 22, 2016 9:07 AM
To: Ding, HengX; dts at dpdk.org
Cc: Ding, HengX
Subject: Re: [dts] [PATCH] l3fwd/testpmd performance: optimize command for testpmd and comment some cases no need to run.
Hi Heng, some comments below.
> -----Original Message-----
> From: dts [mailto:dts-bounces at dpdk.org] On Behalf Of Ding Heng
> Sent: Wednesday, April 20, 2016 10:17 AM
> To: dts at dpdk.org
> Cc: Ding, HengX
> Subject: [dts] [PATCH] l3fwd/testpmd performance: optimize command for
> testpmd and comment some cases no need to run.
> l3fwd: comment 2 cases no need to run in nightly performance test. Fix
> issues for run rfc2544 case with different nic. Add 72 byte for
> performance test.
> testpmd: change report format for generate nightly performance test.
> Use core mask instead of all cores for performance test.
> framework/pmd_output: optimize command for performance, run testpmd in
> vector mode instead of Xmit mode. Optimize core configuration for
> testpmd because run testpmd with all cores will get a bad performance
> Signed-off-by: Ding Heng <hengx.ding at intel.com>
> diff --git a/framework/pmd_output.py b/framework/pmd_output.py index
> df8db12..05e4e04 100644
> --- a/framework/pmd_output.py
> +++ b/framework/pmd_output.py
> @@ -101,14 +101,18 @@ class PmdOutput():
> def start_testpmd(self, cores, param='', eal_param='', socket=0):
> # in dpdk2.0 need used --txqflags param to open hardware
> + # use 0xf01 to enable vector mode and get better performance.
> if "--txqflags" not in param:
> - param += " --txqflags=0"
Please not changed this default value for other suites depend on this. You can appoint this value in performance suite.
> + param += " --txqflags=0xf01"
> if type(cores) == list:
> core_list = cores
> elif cores == "Default":
> core_list = self.dut.get_core_list(self.default_cores)
> + # testpmd could not run with single core, at least 2
> + cores
> are needed.
> + if cores == "1S/1C/1T":
> + cores = "1S/2C/1T"
That's strange logic, please change input core setting as required.
[Qian] Yes, I am also confused first to see it, I know the cores setting about 2C is testpmd used cores since testpmd will have a master core will is not used in packet fwd. So, you can name different, such as testpmd_cores and fwd_cores.
More information about the dts