[dts] [PATCH] ddp_gtp: delete profile instead of core reset before quit testpmd

Xueqin Lin xueqin.lin at intel.com
Mon Apr 9 23:10:47 CEST 2018


Remove profile instead of core reset workaround to
restore original configuration to avoid exception.
---
 test_plans/ddp_gtp_test_plan.rst | 20 +++++++++++---------
 tests/TestSuite_ddp_gtp.py       | 20 ++++++++++++++------
 2 files changed, 25 insertions(+), 15 deletions(-)

diff --git a/test_plans/ddp_gtp_test_plan.rst b/test_plans/ddp_gtp_test_plan.rst
index aedf45f..b471d2b 100644
--- a/test_plans/ddp_gtp_test_plan.rst
+++ b/test_plans/ddp_gtp_test_plan.rst
@@ -92,9 +92,10 @@ Test Case: Load dynamic device personalization
 
     testpmd > port stop all
 
-2. Load profile gtp.pkgo which is a binary file::
+2. Load gtp.pkgo file to the memory buffer, save original configuration
+   and return in the same buffer to the gtp.bak file::
 
-    testpmd > ddp add (port_id) (profile_path)
+    testpmd > ddp add (port_id) /tmp/gtp.pkgo,/tmp/gtp.bak
 
 3. Check profile information successfully::
 
@@ -104,6 +105,13 @@ Test Case: Load dynamic device personalization
 
     testpmd > port start all
 
+Test Case: Delete dynamic device personalization
+================================================
+
+Remove profile from the network adapter and restore original configuration::
+   
+    testpmd > ddp del (port_id) /tmp/gtp.bak
+
 Note:
 
 1. Gtp.pkgo profile is not released by ND yet, only have engineer version for
@@ -112,13 +120,7 @@ Note:
 
 2. Loading DDP is the prerequisite for below GTP relative cases. Load 
    profile again once restarting testpmd to let software detect this 
-   event, although has “profile has already existed” reminder. Operate
-   global reset or lanconf tool to recover original setting. Global reset
-   trigger reg is 0xb8190, first cmd is core reset, second cmd is global
-   reset::
-
-    testpmd > write reg 0 0xb8190 1
-    testpmd > write reg 0 0xb8190 2
+   event, although has “profile has already existed” reminder. 
 	  
 
 Test Case: GTP-C FDIR packet for PF
diff --git a/tests/TestSuite_ddp_gtp.py b/tests/TestSuite_ddp_gtp.py
index d869580..6b6f975 100644
--- a/tests/TestSuite_ddp_gtp.py
+++ b/tests/TestSuite_ddp_gtp.py
@@ -141,7 +141,7 @@ class TestDdpGtp(TestCase):
         self.dut_testpmd.execute_cmd('port stop all')
         time.sleep(1)
         out = self.dut_testpmd.execute_cmd('ddp get list 0')
-        self.dut_testpmd.execute_cmd('ddp add 0 /tmp/gtp.pkgo')
+        self.dut_testpmd.execute_cmd('ddp add 0 /tmp/gtp.pkgo,/tmp/gtp.bak')
         out = self.dut_testpmd.execute_cmd('ddp get list 0')
         self.verify("Profile number is: 1" in out,
                     "Failed to load ddp profile!!!")
@@ -385,11 +385,19 @@ class TestDdpGtp(TestCase):
             type='clfter', port='vf id 0', tunnel_pkt='gtpu', inner_L3='ipv6')
 
     def tear_down(self):
-        if self.vm0_testpmd:
-            self.dut_testpmd.execute_cmd('write reg 0 0xb8190 1')
-            self.dut_testpmd.execute_cmd('write reg 0 0xb8190 2')
-            self.vm0_testpmd.quit()
-            self.dut_testpmd.quit()
+        self.vm0_testpmd.execute_cmd('stop')
+        self.dut_testpmd.execute_cmd('stop')
+        out = self.dut_testpmd.execute_cmd('ddp get list 0')
+        if "Profile number is: 0" not in out:
+            self.dut_testpmd.execute_cmd('port stop all')
+            time.sleep(1)
+            self.dut_testpmd.execute_cmd('ddp del 0 /tmp/gtp.bak')
+            out = self.dut_testpmd.execute_cmd('ddp get list 0')
+            self.verify("Profile number is: 0" in out,
+                        "Failed to delete ddp profile!!!")
+            self.dut_testpmd.execute_cmd('port start all')
+        self.vm0_testpmd.quit()
+        self.dut_testpmd.quit()
 
     def tear_down_all(self):
         self.destroy_vm_env()
-- 
2.5.5



More information about the dts mailing list