[dts] [PATCH V1]tests/shutdown_api: fix the CRC stripping enabled issue
Han, YingyaX
yingyax.han at intel.com
Thu May 17 04:59:10 CEST 2018
The CRC strip defaults to enable and the script has the 'port config all CRC -strip on'. so I used the '-disable- CRC -strip' parameter.
I will modify the script to verify it before set CRC strip on .
-----Original Message-----
From: Liu, Yong
Sent: Thursday, May 17, 2018 10:17 AM
To: Han, YingyaX <yingyax.han at intel.com>; dts at dpdk.org
Cc: Han, YingyaX <yingyax.han at intel.com>
Subject: RE: [dts] [PATCH V1]tests/shutdown_api: fix the CRC stripping enabled issue
Yingya,
One comment below.
Thanks,
Marvin
> -----Original Message-----
> From: dts [mailto:dts-bounces at dpdk.org] On Behalf Of han,yingya
> Sent: Thursday, May 17, 2018 10:10 AM
> To: dts at dpdk.org
> Cc: Han, YingyaX <yingyax.han at intel.com>
> Subject: [dts] [PATCH V1]tests/shutdown_api: fix the CRC stripping
> enabled issue
>
> the output of CRC stripping changed in 18.05 and 'Rx offloads=0x1000'
> is defined as DEV_RX_OFFLOAD_CRC_STRIP.
>
> Signed-off-by: han,yingya <yingyax.han at intel.com>
> ---
> tests/TestSuite_shutdown_api.py | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tests/TestSuite_shutdown_api.py
> b/tests/TestSuite_shutdown_api.py index af0b77d..4c7ca09 100644
> --- a/tests/TestSuite_shutdown_api.py
> +++ b/tests/TestSuite_shutdown_api.py
> @@ -253,8 +253,8 @@ class TestShutdownApi(TestCase):
> self.dut.send_expect("set fwd mac", "testpmd>")
> self.dut.send_expect("port start all", "testpmd> ", 100)
> out = self.dut.send_expect("show config rxtx", "testpmd> ")
> - self.verify("RX queues=2" in out, "RX queues not reconfigured
> properly")
> - self.verify("TX queues=2" in out, "TX queues not reconfigured
> properly")
> + self.verify("RX queue number: 2" in out, "RX queues not
> reconfigured properly")
> + self.verify("Tx queue number: 2" in out, "TX queues not
> reconfigured properly")
> self.dut.send_expect("start", "testpmd> ")
> self.check_forwarding()
> self.dut.send_expect("quit", "# ", 30) @@ -263,7 +263,7 @@
> class TestShutdownApi(TestCase):
> """
> Reconfigure All Ports With The Same Configurations (CRC)
> """
> - self.pmdout.start_testpmd("Default", "--portmask=%s --port-
> topology=loop" % utils.create_mask(self.ports),
> socket=self.ports_socket)
> + self.pmdout.start_testpmd("Default", "--portmask=%s --port-
> topology=loop --disable-crc-strip" % utils.create_mask(self.ports),
> socket=self.ports_socket)
When starting testpmd, crc-strip has been disabled. But in the verify judgement, still check crc-strip enable.
Could you please explain what cause the confiction?
>
> self.dut.send_expect("port stop all", "testpmd> ", 100)
> self.dut.send_expect("port config all crc-strip on",
> "testpmd> ") @@ -271,7 +271,7 @@ class TestShutdownApi(TestCase):
> self.dut.send_expect("port start all", "testpmd> ", 100)
> out = self.dut.send_expect("show config rxtx", "testpmd> ")
> self.verify(
> - "CRC stripping enabled" in out, "CRC stripping not enabled
> properly")
> + "Rx offloads=0x1000" in out, "CRC stripping not enabled
> properly")
> self.dut.send_expect("start", "testpmd> ")
> self.check_forwarding()
>
> --
> 1.9.3
More information about the dts
mailing list