[spp] [PATCH 23/57] spp_vf: display usage message

x-fn-spp at sl.ntt-tx.co.jp x-fn-spp at sl.ntt-tx.co.jp
Thu Dec 28 05:55:30 CET 2017


From: Hiroyuki Nakamura <nakamura.hioryuki at po.ntt-tx.co.jp>

* When there is no required startup parameter,
  usage message will displayed.

Signed-off-by: Kentaro Watanabe <watanabe.kentaro.z01 at as.ntt-tx.co.jp>
Signed-off-by: Yasufum Ogawa <ogawa.yasufumi at lab.ntt.co.jp>
---
 src/vf/spp_vf.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/src/vf/spp_vf.c b/src/vf/spp_vf.c
index 6c6b832..1eaaac9 100644
--- a/src/vf/spp_vf.c
+++ b/src/vf/spp_vf.c
@@ -359,6 +359,8 @@ static int
 parse_app_args(int argc, char *argv[])
 {
 	int cnt;
+	int proc_flg = 0;
+	int server_flg = 0;
 	int option_index, opt;
 	const int argcopt = argc;
 	char *argvopt[argcopt];
@@ -392,6 +394,7 @@ parse_app_args(int argc, char *argv[])
 				usage(progname);
 				return -1;
 			}
+			proc_flg = 1;
 			break;
 		case 's':
 			if (parse_app_server(optarg, g_startup_param.server_ip,
@@ -399,6 +402,7 @@ parse_app_args(int argc, char *argv[])
 				usage(progname);
 				return -1;
 			}
+			server_flg = 1;
 			break;
 		default:
 			usage(progname);
@@ -407,6 +411,11 @@ parse_app_args(int argc, char *argv[])
 		}
 	}
 
+	/* Check mandatory parameters */
+	if ((proc_flg == 0) || (server_flg == 0)) {
+		usage(progname);
+		return -1;
+	}
 	RTE_LOG(INFO, APP, "application arguments value. (process id = %d, config = %s, server = %s:%d)\n",
 			g_startup_param.process_id,
 			config_file_path,
-- 
1.9.1



More information about the spp mailing list