[spp] [PATCH 2/3] docs: correct incorrect SPP git URL

Yasufumi Ogawa ogawa.yasufumi at lab.ntt.co.jp
Fri Jun 15 04:58:04 CEST 2018


On 2018/06/08 18:01, x-fn-spp at sl.ntt-tx.co.jp wrote:
> From: Hiroyuki Nakamura <nakamura.hiroyuki at po.ntt-tx.co.jp>
> 
> This commit correct incorrect SPP git URL.
> 
> Signed-off-by: Hiroyuki Nakamura <nakamura.hiroyuki at po.ntt-tx.co.jp>
> Signed-off-by: Naoki Takada <takada.naoki at lab.ntt.co.jp>
> ---
>   docs/guides/spp_vf/gsg/build.rst | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/docs/guides/spp_vf/gsg/build.rst b/docs/guides/spp_vf/gsg/build.rst
> index 93132d4..e7a2a17 100644
> --- a/docs/guides/spp_vf/gsg/build.rst
> +++ b/docs/guides/spp_vf/gsg/build.rst
> @@ -136,8 +136,8 @@ Clone SPP in any directory and compile it.
>   .. code-block:: console
>   
>       $ cd /path/to/spp_home/
I think that users may be confused for what is 'spp_home' and where is it. You should add an explanation about it if you need to 
move to 'spp_home' dir.
> -    $ git clone https://github.com/ntt-ns/Soft-Patch-Panel.git
> -    export SPP_HOME=/path/to/spp_home/Soft-Patch-Panel
> +    $ git clone http://dpdk.org/git/apps/spp
> +    $ export SPP_HOME=/path/to/spp_home/spp
I think it is no good naming because 'spp_home' is not '$SPP_HOME'. Could you change it to be consistent?

Thanks,
>       $ cd $SPP_HOME
>       $ make
>   
> 


-- 
Yasufumi Ogawa
NTT Network Service Systems Labs



More information about the spp mailing list