[spp] [spp 03234] [PATCH 0/2] Fix compile error with DPDK v18.08

[Hideyuki Yamashita]

Hello Yasufumi-san,

My suggestion is to apply the first patch soon
because without that patch, compile of spp encounters error.
Soon is better.

About replacing deprecaed functions, I am planning to provide patch 
after the above mentioned patch applied to master.

BR,
Hideyuki Yamashita
NTT TechnoCross

> Hi Hideyuki,
> 
> Could you tell me what is the point of your suggestion?
> 
> I agreed not to disable warning option in Makefile and need to update for DPDK v18.08 by replacing deprecated functions. I think it is still required to remove deprecated `txq_flags` if update to v18.08. However, I am not sure if you suggest to apply the first patch soon, or it is OK later.
> 
> Thanks,
> Yasufumi
> 
> > Hello,
> >
> > So far, it looks both patches are not merged into master branch.
> > I think change on makefile is tentative one and no need to merge.
> > But the other change on shared needs to be merged to master
> > because it is essentical change.
> >
> > BR,
> > Hideyuki Yamashita
> > NTT TechnoCross
> >
> >> From: Yasufumi Ogawa <ogawa.yasufumi at lab.ntt.co.jp>
> >>
> >> Compiling SPP with DPDK v18.08 causes some of erros and warnings
> >> because of following reasons. This series of patches is to fix them.
> >>
> >> * Tx queue configuration is not updated for the new Tx offload API.
> >>
> >> * rte_eth_dev_attach/detach is deprecated but still remained.
> >>
> >> Yasufumi Ogawa (2):
> >>    shared: remove nouse txq_flags
> >>    makefile: ignore deprecated declarations
> >>
> >>   src/nfv/Makefile    | 1 +
> >>   src/shared/common.c | 1 -
> >>   src/vf/Makefile     | 1 +
> >>   src/vm/Makefile     | 1 +
> >>   4 files changed, 3 insertions(+), 1 deletion(-)
> >>
> >> --
> >> 2.7.4