[spp] [PATCH v2 0/6] Replace deprecated APIs
Yasufumi Ogawa
geminoa at juno.ocn.ne.jp
Sat Nov 24 13:57:36 CET 2018
>>From DPDK 18.08, following APIs become deprecated and will be deleted in 18.11.
> - rte_eth_dev_attach()
> - rte_eth_dev_detach()
>
> It is recommended to use followings.
> - rte_eth_dev_attach() should be replaced by rte_eal_hotplug_add().
> - rte_eth_dev_detach() should be replaced by rte_eal_hotplug_remove().
>
> This series of patches is to update for the changes.
> - Add dev_attach_by_devargs() as replacement of rte_eth_dev_attach(). This function
> calls rte_eal_hotplug_add() to hotplug device for given name "devargs",and returns
> newly allocated dpdk port_id.
> - Add dev_detach_by_port_id() as replacement of rte_eth_dev_detach(). This function
> calls rte_eal_hotplug_remove() to detach device for given port_id.
> - Replace rte_eth_dev_attach() in spp_nfv and spp_vf with dev_attach_by_devargs().
> - Replace rte_eth_dev_attach() in spp_nfv and spp_vf with dev_detach_by_port_id().
Hideyuki,
Your patches cause compile errors because DPDK APIs you use instead of
depricated APIs are still not stable. You should add
`-DALLOW_EXPERIMENTAL_API` to CFLAG option in each of Makefiles of SPP
processes.
I already fixed this bug while I checked your patches. I would like to
send patches to fix this bug.
Thanks,
Yasufumi
>
> Hideyuki Yamashita (6):
> shared: add dev_attach_by_devargs
> spp_nfv: replace deprecated rte_eth_dev_attach
> spp_vf: replace deprecated rte_eth_dev_attach
> shared: add dev_detach_by_port_id
> spp_nfv: replace deprecated rte_eth_dev_detach
> spp_vm: replace deprecated rte_eth_dev_detach
>
> src/nfv/nfv.c | 18 +++++--------
> src/shared/common.c | 64 +++++++++++++++++++++++++++++++++++++++++++++
> src/shared/common.h | 29 ++++++++++++++++++++
> src/vf/spp_vf.c | 4 +--
> src/vm/main.c | 4 +--
> 5 files changed, 102 insertions(+), 17 deletions(-)
>
More information about the spp
mailing list