[spp] [PATCH 00/23] move some codes of spp_vf into vf/common
Yasufumi Ogawa
geminoa at juno.ocn.ne.jp
Sat Nov 24 14:15:15 CET 2018
> Some spp_vf codes can be used by new secondary process which
> is extended from spp_vf. This patch set move such codes into
> spp_vf/common.
Hideyuki,
Your update of `spp_convert_component_type()` in `command_dec.c` has a
problem because `type_str` variable is only used in `ifdef` preprocessor
directive and it is considered as not used by compiler. It causes a
compile error, so should be fixed.
I fixed this error by adding RTE_LOG() outside the preprocessor
directive to avoid the error as following. I would like send patch if it
is agreeable.
RTE_LOG(DEBUG, APP, "type_str is %s\n", type_str);
Thanks,
Yasufumi
>
> Hideyuki Yamashita (23):
> spp_vf: fix invalid code for max chars
> spp_vf: move common source and header files
> spp_vf: change include path
> spp_vf: update Makefile for common files
> spp_vf: move functions to common directory
> spp_vf: move defines to common dir
> spp_vf: move functions for decode to common dir
> spp_vf: move defines for decode to common dir
> spp_vf: move functions to command_proc.c
> spp_vf: add management data registration
> spp_vf: change reference of management data
> spp_vf: change return values to explain result
> spp_vf: define terms of commands as consts
> spp_vf: remove unnecessary includes
> spp_vf: add include header files
> spp_vf: update comments for header file
> spp_vf: update makefile of spp_vf
> spp_vf: add check num of ports before forwarding
> spp_vf: add flag for classifier table
> spp_vf: add checking the number of ports
> spp_vf: add vlantag command check flag
> spp_vf: simplify changing VLAN tag
> spp_vf: add SPP_VF_MODULE preprocessor directive
>
> src/vf/Makefile | 7 +-
> src/vf/classifier_mac.c | 139 ++-
> src/vf/classifier_mac.h | 20 +-
> src/vf/{ => common}/command_conn.c | 23 +-
> src/vf/{ => common}/command_conn.h | 16 +-
> src/vf/{ => common}/command_dec.c | 641 +++++++---
> src/vf/{ => common}/command_dec.h | 21 +-
> src/vf/{ => common}/command_proc.c | 716 +++++++++--
> src/vf/{ => common}/command_proc.h | 10 +-
> src/vf/{ => common}/ringlatencystats.c | 15 +-
> src/vf/{ => common}/ringlatencystats.h | 4 +-
> src/vf/{ => common}/spp_port.c | 34 +-
> src/vf/{ => common}/spp_port.h | 2 +-
> src/vf/common/spp_proc.c | 1029 ++++++++++++++++
> src/vf/common/spp_proc.h | 727 +++++++++++
> src/vf/{ => common}/string_buffer.c | 3 +-
> src/vf/{ => common}/string_buffer.h | 0
> src/vf/spp_forward.c | 47 +-
> src/vf/spp_forward.h | 12 +-
> src/vf/spp_vf.c | 1574 +-----------------------
> src/vf/spp_vf.h | 511 --------
> 21 files changed, 3074 insertions(+), 2477 deletions(-)
> rename src/vf/{ => common}/command_conn.c (90%)
> rename src/vf/{ => common}/command_conn.h (82%)
> rename src/vf/{ => common}/command_dec.c (53%)
> rename src/vf/{ => common}/command_dec.h (90%)
> rename src/vf/{ => common}/command_proc.c (63%)
> rename src/vf/{ => common}/command_proc.h (80%)
> rename src/vf/{ => common}/ringlatencystats.c (92%)
> rename src/vf/{ => common}/ringlatencystats.h (97%)
> rename src/vf/{ => common}/spp_port.c (94%)
> rename src/vf/{ => common}/spp_port.h (99%)
> create mode 100644 src/vf/common/spp_proc.c
> create mode 100644 src/vf/common/spp_proc.h
> rename src/vf/{ => common}/string_buffer.c (97%)
> rename src/vf/{ => common}/string_buffer.h (100%)
>
More information about the spp
mailing list