[spp] [PATCH] spp-ctl: SPP controller with Web API

[Itsuro ODA]

Yasufumi,

Thank you for the comment.

OK, I will revise the patch and post it again according to
your suggestion.

Thanks.
Itsuro Oda

On Tue, 18 Sep 2018 19:00:08 +0900
Yasufumi Ogawa <ogawa.yasufumi at lab.ntt.co.jp> wrote:

> > spp-ctl is a SPP controller with a REST like web API.
> > > spp-ctl maintains the connections from the SPP processes and at
> > the same time exposes the API for the user to request for the
> > SPP processes.
> > > Background and motivation:
> > > Current CLI (spp.py/spp_vf.py) can be used by intaractive only.
> > Therefore, spp-agent, a component of networking-spp which make
> > SPP available on OpenStack environment, implements SPP controller
> > in itself. (see. https://github.com/openstack/networking-spp )
> > > Either CLI or spp-agent, there is a problem that other people can
> > not request to SPP processes while using. spp-ctl is invented to
> > solve this problem.
> > > Both CLI and spp-agent can be used spp-ctl to request SPP
> > processes instead of owning contoroller itself. In that case,
> > multiple people can request to SPP processes at the same time.
> > Note that spp-agent has a plan to change to use spp-ctl.
> > It is also available not using CLI but requesting spp-ctl
> > directly.
> Hi Itsuro,
> 
> Thanks a lot for your proposal and contribution! It looks well defined APIs for existing SPP commands. I think it is also a good idea to fill the gap between usages of CLI and OpenStack.
> 
> For considering our conventions, I would like to ask you to revise your patch for the reasons described below.
> 
> * Patch should be divided into several patches for each of files if you add newly created files because it is difficult to understand the status of review if it is not divided.
> 
> * All of documentation should be contained in `docs/guides`. Your proposal is for adding new entity and it need to create a new sub-directory. I think `docs/guides/spp-ctl` is appropriate.
> 
> * `index.rst` is required in `docs/guides/spp-ctl`.
> 
> * It is better to rename `README.rst` to `overview.rst` for the convention.
> 
> * `requirements.txt` should not be included in `src` directory. Do you think to move it to the project root?
> 
> Thanks,
> Yasufumi

-- 
Itsuro ODA <oda at valinux.co.jp>