[spp] [spp 04700] Re: [PATCH 0/2] support of RPM install on CentOS

[Yasufumi Ogawa]

On 2019/12/19 11:38, Hideyuki Yamashita wrote:
> Hi Yasufumi,
> 
> Please see inline.
> 
>> On 2019/12/18 11:00, Hideyuki Yamashita wrote:
>>> Hi Yasufumi,
>>>
>>> You are correct.
>>> Patch set is intened to update v18.08.4 branch not master.
>>> I appologize to confuse.
>>>
>>> If I have to update patch set itself with reagrd to the targeting
>>> version, please let me know.
>>>
>>> Thanks in advance.
>> LGTM, but I have a question and a comment.
>>
>> What do you think to provide rpm for the latest SPP?
> If I have a chance to test SPP on latest DPDK and if some updates needed
> then I will request changes on master.
> 
>>   > docs: add RPM installation for DPDK and SPP
>> It is more appropriate to use another label instead of 'docs' because your spec file is not included in docs. I'd like to suggest you to use the name of directory 'rpmbuild' simply. If you agree, I'd change the label while applying the change.
> No problem about your changing label on patchset (spec file).
> 
> Thanks!
> BR,
> HIdeyuki Yamashita
> NTT TechnoCross
Applied, thank.

Acked-by: Yasufumi Ogawa <yasufum.o at gmail.com>
> 
> 
>> Thanks,
>> Yasufumi
>>>
>>> BR,
>>> Hideyui Yamashita
>>> NTT TechnoCross
>>>
>>>> Hi Hideyuki,
>>>>
>>>> I'm not sure the version of SPP because this update looks describing for v18.08.4 while the latest SPP is 19.08. Are you targeting not the master branch but v18.08.4 branch?
>>>>
>>>> Yasufumi
>>>>
>>>> On 2019/12/16 18:17, x-fn-spp at sl.ntt-tx.co.jp wrote:
>>>>> From: Hideyuki Yamashita <yamashita.hideyuki at po.ntt-tx.co.jp>
>>>>>
>>>>> So far installation of SPP is done by making source code.
>>>>> It is convenient for some users to install SPP using RPM.
>>>>> This patch set provides spec file of SPP to generate RPM of SPP.
>>>>> RST document is also updated to support this type of installation.
>>>>>
>>>>> Hideyuki Yamashita (2):
>>>>>      docs: add RPM installation for DPDK and SPP
>>>>>      docs: introduce RPM package support
>>>>>
>>>>>     docs/guides/gsg/install.rst | 307 +++++++++++++++++++++++++++++++++++-
>>>>>     rpmbuild/SPECS/spp.spec     | 222 ++++++++++++++++++++++++++
>>>>>     2 files changed, 521 insertions(+), 8 deletions(-)
>>>>>     create mode 100644 rpmbuild/SPECS/spp.spec
>>>>>
>>>
>>>
>>>
> 
>