[spp] [PATCH] tools/sppc: improvement of Dockerfile for SPP container

[Itsuro ODA]

Hi Yasufumi,

The spp_mirror container surely ran with networking-spp k8s
environment.
About the spp_pcap container, it is confirmed to start at
least although detailed test are not done. 

Thanks.
Itsuro Oda

On Tue, 16 Jun 2020 18:33:32 +0900
Yasufumi Ogawa <yasufum.o at gmail.com> wrote:

> > This patch includes some improvements of Dockerfile used by
> > building SPP containers.
> >
> > * remove a nonexistent command path
> > * add some useful command paths
> > * specify a value of 'make -j' option of making DPDK not to
> >    exhaust system resources by compiling processes.
> I totally agree with your changes, but have one thing to be confirmed.
> 
> I remember that I haven't included spp_mirror and spp_pcap in apps in SPP container because I don't have tested well yet. Have you confirmed that these app run on container env?
> 
> >
> > Signed-off-by: Itsuro Oda <oda at valinux.co.jp>
> > ---
> >   tools/sppc/build/ubuntu/spp/Dockerfile.16.04  | 5 +++--
> >   tools/sppc/build/ubuntu/spp/Dockerfile.18.04  | 5 +++--
> >   tools/sppc/build/ubuntu/spp/Dockerfile.latest | 5 +++--
> >   3 files changed, 9 insertions(+), 6 deletions(-)
> >
> > diff --git a/tools/sppc/build/ubuntu/spp/Dockerfile.16.04 b/tools/sppc/build/ubuntu/spp/Dockerfile.16.04
> > index 3e060df..7c81b3a 100644
> > --- a/tools/sppc/build/ubuntu/spp/Dockerfile.16.04
> > +++ b/tools/sppc/build/ubuntu/spp/Dockerfile.16.04
> > @@ -19,7 +19,8 @@ ENV PATH ${rte_sdk}/${rte_target}/app:${PATH}
> >   ENV PATH ${home_dir}/${spp_dir}/src/primary/${rte_target}/:${PATH}
> >   ENV PATH ${home_dir}/${spp_dir}/src/nfv/${rte_target}/:${PATH}
> >   ENV PATH ${home_dir}/${spp_dir}/src/vf/${rte_target}/:${PATH}
> > -ENV PATH ${home_dir}/${spp_dir}/src/vm/${rte_target}/:${PATH}
> > +ENV PATH ${home_dir}/${spp_dir}/src/mirror/${rte_target}/:${PATH}
> > +ENV PATH ${home_dir}/${spp_dir}/src/pcap/${rte_target}/:${PATH}
> >  >   WORKDIR $home_dir
> >   RUN git clone ${dpdk_branch} ${dpdk_repo}
> > @@ -27,7 +28,7 @@ RUN git clone ${spp_branch} ${spp_repo}
> >  >   # Compile DPDK and SPP
> >   WORKDIR ${rte_sdk}
> > -RUN make -j install T=${rte_target}
> > +RUN make -j 4 install T=${rte_target}
> >  >   WORKDIR ${home_dir}/${spp_dir}
> >   RUN make -j
> > diff --git a/tools/sppc/build/ubuntu/spp/Dockerfile.18.04 b/tools/sppc/build/ubuntu/spp/Dockerfile.18.04
> > index e35fbc2..9b90dd4 100644
> > --- a/tools/sppc/build/ubuntu/spp/Dockerfile.18.04
> > +++ b/tools/sppc/build/ubuntu/spp/Dockerfile.18.04
> > @@ -19,7 +19,8 @@ ENV PATH ${rte_sdk}/${rte_target}/app:${PATH}
> >   ENV PATH ${home_dir}/${spp_dir}/src/primary/${rte_target}/:${PATH}
> >   ENV PATH ${home_dir}/${spp_dir}/src/nfv/${rte_target}/:${PATH}
> >   ENV PATH ${home_dir}/${spp_dir}/src/vf/${rte_target}/:${PATH}
> > -ENV PATH ${home_dir}/${spp_dir}/src/vm/${rte_target}/:${PATH}
> > +ENV PATH ${home_dir}/${spp_dir}/src/mirror/${rte_target}/:${PATH}
> > +ENV PATH ${home_dir}/${spp_dir}/src/pcap/${rte_target}/:${PATH}
> >   ENV DEBIAN_FRONTEND noninteractive
> >  >   WORKDIR $home_dir
> > @@ -28,7 +29,7 @@ RUN git clone ${spp_branch} ${spp_repo}
> >  >   # Compile DPDK and SPP
> >   WORKDIR ${rte_sdk}
> > -RUN make -j install T=${rte_target}
> > +RUN make -j 4 install T=${rte_target}
> >  >   WORKDIR ${home_dir}/${spp_dir}
> >   RUN make -j
> > diff --git a/tools/sppc/build/ubuntu/spp/Dockerfile.latest b/tools/sppc/build/ubuntu/spp/Dockerfile.latest
> > index a1ffc80..7e6f5ac 100644
> > --- a/tools/sppc/build/ubuntu/spp/Dockerfile.latest
> > +++ b/tools/sppc/build/ubuntu/spp/Dockerfile.latest
> > @@ -19,7 +19,8 @@ ENV PATH ${rte_sdk}/${rte_target}/app:${PATH}
> >   ENV PATH ${home_dir}/${spp_dir}/src/primary/${rte_target}/:${PATH}
> >   ENV PATH ${home_dir}/${spp_dir}/src/nfv/${rte_target}/:${PATH}
> >   ENV PATH ${home_dir}/${spp_dir}/src/vf/${rte_target}/:${PATH}
> > -ENV PATH ${home_dir}/${spp_dir}/src/vm/${rte_target}/:${PATH}
> > +ENV PATH ${home_dir}/${spp_dir}/src/mirror/${rte_target}/:${PATH}
> > +ENV PATH ${home_dir}/${spp_dir}/src/pcap/${rte_target}/:${PATH}
> >   ENV DEBIAN_FRONTEND noninteractive
> >  >   WORKDIR $home_dir
> > @@ -28,7 +29,7 @@ RUN git clone ${spp_branch} ${spp_repo}
> >  >   # Compile DPDK and SPP
> >   WORKDIR ${rte_sdk}
> > -RUN make -j install T=${rte_target}
> > +RUN make -j 4 install T=${rte_target}
> >  >   WORKDIR ${home_dir}/${spp_dir}
> >   RUN make -j
> > 

-- 
Itsuro ODA <oda at valinux.co.jp>