[dpdk-stable] patch 'app/testpmd: fix duplicate exit' has been queued to stable release 18.08.1
Kevin Traynor
ktraynor at redhat.com
Wed Nov 21 17:48:13 CET 2018
Hi,
FYI, your patch has been queued to stable release 18.08.1
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/27/18. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the patch applied
to the branch. If the code is different (ie: not only metadata diffs), due for example to
a change in context or macro names, please double check it.
Thanks.
Kevin Traynor
---
>From 2fe9b7d8ecb68a7640d01ba850bdc928b07ce153 Mon Sep 17 00:00:00 2001
From: Brian Archbold <brian.archbold at intel.com>
Date: Wed, 22 Aug 2018 07:05:06 +0100
Subject: [PATCH] app/testpmd: fix duplicate exit
[ upstream commit 27c7031e0b49abbaf13ea4c4a809a07b9282422d ]
In interactive mode, when the "quit" command is issued, pmd_test_exit()
is being called twice, once through the "quit" command and the other
after termination of prompt.
Remove duplicated exit routine by removing call from "quit" command.
Steps to reproduce:
- Run testpmd in interactive mode.
- type "quit".
Fixes: af75078fece3 ("first public release")
Signed-off-by: Brian Archbold <brian.archbold at intel.com>
Acked-by: Bernard Iremonger <bernard.iremonger at intel.com>
---
app/test-pmd/cmdline.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 4645c7840..69c8e0499 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -7556,5 +7556,4 @@ static void cmd_quit_parsed(__attribute__((unused)) void *parsed_result,
__attribute__((unused)) void *data)
{
- pmd_test_exit();
cmdline_quit(cl);
}
--
2.19.0
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2018-11-21 16:44:32.555701548 +0000
+++ 0059-app-testpmd-fix-duplicate-exit.patch 2018-11-21 16:44:30.000000000 +0000
@@ -1,8 +1,10 @@
-From 27c7031e0b49abbaf13ea4c4a809a07b9282422d Mon Sep 17 00:00:00 2001
+From 2fe9b7d8ecb68a7640d01ba850bdc928b07ce153 Mon Sep 17 00:00:00 2001
From: Brian Archbold <brian.archbold at intel.com>
Date: Wed, 22 Aug 2018 07:05:06 +0100
Subject: [PATCH] app/testpmd: fix duplicate exit
+[ upstream commit 27c7031e0b49abbaf13ea4c4a809a07b9282422d ]
+
In interactive mode, when the "quit" command is issued, pmd_test_exit()
is being called twice, once through the "quit" command and the other
after termination of prompt.
@@ -14,7 +16,6 @@
- type "quit".
Fixes: af75078fece3 ("first public release")
-Cc: stable at dpdk.org
Signed-off-by: Brian Archbold <brian.archbold at intel.com>
Acked-by: Bernard Iremonger <bernard.iremonger at intel.com>
@@ -23,10 +24,10 @@
1 file changed, 1 deletion(-)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
-index 1b40e3fa8..dd5616d35 100644
+index 4645c7840..69c8e0499 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
-@@ -7671,5 +7671,4 @@ static void cmd_quit_parsed(__attribute__((unused)) void *parsed_result,
+@@ -7556,5 +7556,4 @@ static void cmd_quit_parsed(__attribute__((unused)) void *parsed_result,
__attribute__((unused)) void *data)
{
- pmd_test_exit();
More information about the stable
mailing list