[dpdk-stable] [PATCH 1/3] net/enic: fix flow API memory leak

Yongseok Koh yskoh at mellanox.com
Thu Oct 4 23:35:40 CEST 2018


> On Sep 27, 2018, at 6:51 PM, John Daley <johndale at cisco.com> wrote:
> 
> rte_flow structures were not being freed when destroyed or flushed.
> 
> Fixes: 6ced137607d0 ("net/enic: flow API for NICs with advanced filters enabled")
> Cc: stable at dpdk.org
> 
> Signed-off-by: Hyong Youb Kim <hyonkim at cisco.com>
> Reviewed-by: John Daley <johndale at cisco.com>
> ---

Hi,

Is this patch only for stable releases? If so, which one? Or was dev@
absent by mistake?


Thanks,
Yongseok

> drivers/net/enic/enic_flow.c | 2 ++
> 1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/enic/enic_flow.c b/drivers/net/enic/enic_flow.c
> index 0cf04aefd..9b612f1d5 100644
> --- a/drivers/net/enic/enic_flow.c
> +++ b/drivers/net/enic/enic_flow.c
> @@ -1532,6 +1532,7 @@ enic_flow_destroy(struct rte_eth_dev *dev, struct rte_flow *flow,
> 	enic_flow_del_filter(enic, flow->enic_filter_id, error);
> 	LIST_REMOVE(flow, next);
> 	rte_spinlock_unlock(&enic->flows_lock);
> +	rte_free(flow);
> 	return 0;
> }
> 
> @@ -1555,6 +1556,7 @@ enic_flow_flush(struct rte_eth_dev *dev, struct rte_flow_error *error)
> 		flow = LIST_FIRST(&enic->flows);
> 		enic_flow_del_filter(enic, flow->enic_filter_id, error);
> 		LIST_REMOVE(flow, next);
> +		rte_free(flow);
> 	}
> 	rte_spinlock_unlock(&enic->flows_lock);
> 	return 0;
> -- 
> 2.16.2
> 



More information about the stable mailing list