[dpdk-stable] patch 'test/hash: fix bucket size in perf test' has been queued to LTS release 16.11.9

[Luca Boccassi]

Hi,

FYI, your patch has been queued to LTS release 16.11.9

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 10/31/18. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the patch applied
to the branch. If the code is different (ie: not only metadata diffs), due for example to
a change in context or macro names, please double check it.

Thanks.

Luca Boccassi

---
>From 84a8bcf5118a58ab7b8c3c5912d13f3b650ae4cc Mon Sep 17 00:00:00 2001
From: Yipeng Wang <yipeng1.wang at intel.com>
Date: Fri, 28 Sep 2018 07:11:05 -0700
Subject: [PATCH] test/hash: fix bucket size in perf test

[ upstream commit b772a15eb84ce616114880a20ad6ad91bb8970fc ]

The bucket size was changed from 4 to 8 but the corresponding
perf test was not changed accordingly.

In the test, the bucket size and number of buckets are used
to map to the underneath rte_hash structure. They are used
to test performance of two conditions: keys in primary
buckets only and keys in both primary and secondary buckets.

Although there is no functional issue with bucket size set
to 4, it mismatches the underneath rte_hash structure,
which may affect code readability and future extension.

Fixes: 58017c98ed53 ("hash: add vectorized comparison")

Signed-off-by: Yipeng Wang <yipeng1.wang at intel.com>
Acked-by: Bruce Richardson <bruce.richardson at intel.com>
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli at arm.com>
---
 app/test/test_hash_perf.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/app/test/test_hash_perf.c b/app/test/test_hash_perf.c
index c0051b20f..b0514b104 100644
--- a/app/test/test_hash_perf.c
+++ b/app/test/test_hash_perf.c
@@ -49,7 +49,8 @@
 #define MAX_ENTRIES (1 << 19)
 #define KEYS_TO_ADD (MAX_ENTRIES * 3 / 4) /* 75% table utilization */
 #define NUM_LOOKUPS (KEYS_TO_ADD * 5) /* Loop among keys added, several times */
-#define BUCKET_SIZE 4
+/* BUCKET_SIZE should be same as RTE_HASH_BUCKET_ENTRIES in rte_hash library */
+#define BUCKET_SIZE 8
 #define NUM_BUCKETS (MAX_ENTRIES / BUCKET_SIZE)
 #define MAX_KEYSIZE 64
 #define NUM_KEYSIZES 10
-- 
2.19.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2018-10-29 12:48:14.568269644 +0000
+++ 0005-test-hash-fix-bucket-size-in-perf-test.patch	2018-10-29 12:48:14.434417982 +0000
@@ -1,8 +1,10 @@
-From b772a15eb84ce616114880a20ad6ad91bb8970fc Mon Sep 17 00:00:00 2001
+From 84a8bcf5118a58ab7b8c3c5912d13f3b650ae4cc Mon Sep 17 00:00:00 2001
 From: Yipeng Wang <yipeng1.wang at intel.com>
 Date: Fri, 28 Sep 2018 07:11:05 -0700
 Subject: [PATCH] test/hash: fix bucket size in perf test
 
+[ upstream commit b772a15eb84ce616114880a20ad6ad91bb8970fc ]
+
 The bucket size was changed from 4 to 8 but the corresponding
 perf test was not changed accordingly.
 
@@ -16,20 +18,19 @@
 which may affect code readability and future extension.
 
 Fixes: 58017c98ed53 ("hash: add vectorized comparison")
-Cc: stable at dpdk.org
 
 Signed-off-by: Yipeng Wang <yipeng1.wang at intel.com>
 Acked-by: Bruce Richardson <bruce.richardson at intel.com>
 Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli at arm.com>
 ---
- test/test/test_hash_perf.c | 3 ++-
+ app/test/test_hash_perf.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
 
-diff --git a/test/test/test_hash_perf.c b/test/test/test_hash_perf.c
-index 33dcb9fcf..fe116326d 100644
---- a/test/test/test_hash_perf.c
-+++ b/test/test/test_hash_perf.c
-@@ -20,7 +20,8 @@
+diff --git a/app/test/test_hash_perf.c b/app/test/test_hash_perf.c
+index c0051b20f..b0514b104 100644
+--- a/app/test/test_hash_perf.c
++++ b/app/test/test_hash_perf.c
+@@ -49,7 +49,8 @@
  #define MAX_ENTRIES (1 << 19)
  #define KEYS_TO_ADD (MAX_ENTRIES * 3 / 4) /* 75% table utilization */
  #define NUM_LOOKUPS (KEYS_TO_ADD * 5) /* Loop among keys added, several times */