[dpdk-stable] [PATCH v2 1/2] metrics: new API to deinitialise metrics library

Thomas Monjalon thomas at monjalon.net
Fri Apr 5 15:14:09 CEST 2019


01/03/2019 11:00, Harman Kalra:
> Once the library usage is over, it must be deinitialized which
> will free the shared memory reserved during initialization.
> 
> Fixes: observed an issue while running 'metrics_autotest'
> continuously without quiting. For the first run 'metrics_autotest'
> passes all test cases but second run onwards first test case
> fails because metrics library is already initialized during
> first run.
> Cc: stable at dpdk.org
> 
> Signed-off-by: Harman Kalra <hkalra at marvell.com>

I was waiting for an ack on this patch,
and realized that there was one already on v1.
When sending v2, you should have reported the Ack.
And to ease review between versions, please keep all the versions
in the same thread with --in-reply-to.
Would be nice if old contributors from Marvell would guide you.
Thanks

> ---
> v2:
> * Adding stable at dpdk.org into cc as this patch falls between bug fix
> and new feature.

I would vote for not backporting this new API.
Any other opinion?





More information about the stable mailing list