[dpdk-stable] patch 'test/crypto: fix possible overflow using strlcat' has been queued to LTS release 18.11.2

[Kevin Traynor]

Hi,

FYI, your patch has been queued to LTS release 18.11.2

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 04/24/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Kevin Traynor

---
>From f5c74ea2816cbacf857a167c1370ba693981c9c3 Mon Sep 17 00:00:00 2001
From: Chaitanya Babu Talluri <tallurix.chaitanya.babu at intel.com>
Date: Mon, 18 Mar 2019 12:36:36 +0000
Subject: [PATCH] test/crypto: fix possible overflow using strlcat

[ upstream commit e3b91a3ef236b3bb6ee4db12cc285e8f87b942e7 ]

strcat does not check the destination length and there might be
chances of string overflow so instead of strcat, strlcat is used.

Fixes: 6f4eec2565 ("test/crypto: enhance scheduler unit tests")

Signed-off-by: Chaitanya Babu Talluri <tallurix.chaitanya.babu at intel.com>
Acked-by: Akhil Goyal <akhil.goyal at nxp.com>
---
 test/test/test_cryptodev.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/test/test/test_cryptodev.c b/test/test/test_cryptodev.c
index 84065eb49..fbe8c21e6 100644
--- a/test/test/test_cryptodev.c
+++ b/test/test/test_cryptodev.c
@@ -16,4 +16,5 @@
 #include <rte_cryptodev.h>
 #include <rte_cryptodev_pmd.h>
+#include <rte_string_fns.h>
 
 #ifdef RTE_LIBRTE_PMD_CRYPTO_SCHEDULER
@@ -375,5 +376,5 @@ testsuite_setup(void)
 					"%s%d", temp_str, i);
 			strcpy(temp_str, vdev_args);
-			strcat(temp_str, ";");
+			strlcat(temp_str, ";", sizeof(temp_str));
 			slave_core_count++;
 			socket_id = lcore_config[i].socket_id;
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-04-16 15:34:27.392951174 +0100
+++ 0049-test-crypto-fix-possible-overflow-using-strlcat.patch	2019-04-16 15:34:25.230178840 +0100
@@ -1,31 +1,32 @@
-From e3b91a3ef236b3bb6ee4db12cc285e8f87b942e7 Mon Sep 17 00:00:00 2001
+From f5c74ea2816cbacf857a167c1370ba693981c9c3 Mon Sep 17 00:00:00 2001
 From: Chaitanya Babu Talluri <tallurix.chaitanya.babu at intel.com>
 Date: Mon, 18 Mar 2019 12:36:36 +0000
 Subject: [PATCH] test/crypto: fix possible overflow using strlcat
 
+[ upstream commit e3b91a3ef236b3bb6ee4db12cc285e8f87b942e7 ]
+
 strcat does not check the destination length and there might be
 chances of string overflow so instead of strcat, strlcat is used.
 
 Fixes: 6f4eec2565 ("test/crypto: enhance scheduler unit tests")
-Cc: stable at dpdk.org
 
 Signed-off-by: Chaitanya Babu Talluri <tallurix.chaitanya.babu at intel.com>
 Acked-by: Akhil Goyal <akhil.goyal at nxp.com>
 ---
- app/test/test_cryptodev.c | 3 ++-
+ test/test/test_cryptodev.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
 
-diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
-index 32f1893bc..2ff204137 100644
---- a/app/test/test_cryptodev.c
-+++ b/app/test/test_cryptodev.c
+diff --git a/test/test/test_cryptodev.c b/test/test/test_cryptodev.c
+index 84065eb49..fbe8c21e6 100644
+--- a/test/test/test_cryptodev.c
++++ b/test/test/test_cryptodev.c
 @@ -16,4 +16,5 @@
  #include <rte_cryptodev.h>
  #include <rte_cryptodev_pmd.h>
 +#include <rte_string_fns.h>
  
  #ifdef RTE_LIBRTE_PMD_CRYPTO_SCHEDULER
-@@ -376,5 +377,5 @@ testsuite_setup(void)
+@@ -375,5 +376,5 @@ testsuite_setup(void)
  					"%s%d", temp_str, i);
  			strcpy(temp_str, vdev_args);
 -			strcat(temp_str, ";");