[dpdk-stable] patch 'test/event: replace sprintf with snprintf' has been queued to LTS release 18.11.2

Kevin Traynor ktraynor at redhat.com
Thu Apr 25 17:40:15 CEST 2019


Hi,

FYI, your patch has been queued to LTS release 18.11.2

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 05/01/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches can be viewed on the 18.11 branch at:
	https://github.com/kevintraynor/dpdk-stable-queue.git

Thanks.

Kevin Traynor

---
>From e4e2456fb034fe4fa81f5f8cc7881ee4fc49dc2d Mon Sep 17 00:00:00 2001
From: Pallantla Poornima <pallantlax.poornima at intel.com>
Date: Wed, 6 Feb 2019 10:43:42 +0000
Subject: [PATCH] test/event: replace sprintf with snprintf

[ upstream commit 64fc990877cdfe1973a18f47e6887e8a141a6efb ]

sprintf function is not secure as it doesn't check the length of string.
More secure function snprintf is used.

Fixes: 2a9c83ae3b ("test/eventdev: add multi-ports test")

Signed-off-by: Pallantla Poornima <pallantlax.poornima at intel.com>
---
 test/test/test_event_eth_rx_adapter.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/test/test/test_event_eth_rx_adapter.c b/test/test/test_event_eth_rx_adapter.c
index 1d3be82b5..38f5c039f 100644
--- a/test/test/test_event_eth_rx_adapter.c
+++ b/test/test/test_event_eth_rx_adapter.c
@@ -480,5 +480,6 @@ adapter_multi_eth_add_del(void)
 	port_index = rte_eth_dev_count_total();
 	for (; port_index < RTE_MAX_ETHPORTS; port_index += 1) {
-		sprintf(driver_name, "%s%u", "net_null", drv_id);
+		snprintf(driver_name, sizeof(driver_name), "%s%u", "net_null",
+				drv_id);
 		err = rte_vdev_init(driver_name, NULL);
 		TEST_ASSERT(err == 0, "Failed driver %s got %d",
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-04-25 16:37:48.478599240 +0100
+++ 0040-test-event-replace-sprintf-with-snprintf.patch	2019-04-25 16:37:46.750294835 +0100
@@ -1 +1 @@
-From 64fc990877cdfe1973a18f47e6887e8a141a6efb Mon Sep 17 00:00:00 2001
+From e4e2456fb034fe4fa81f5f8cc7881ee4fc49dc2d Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 64fc990877cdfe1973a18f47e6887e8a141a6efb ]
+
@@ -10 +11,0 @@
-Cc: stable at dpdk.org
@@ -14 +15 @@
- app/test/test_event_eth_rx_adapter.c | 3 ++-
+ test/test/test_event_eth_rx_adapter.c | 3 ++-
@@ -17 +18 @@
-diff --git a/app/test/test_event_eth_rx_adapter.c b/app/test/test_event_eth_rx_adapter.c
+diff --git a/test/test/test_event_eth_rx_adapter.c b/test/test/test_event_eth_rx_adapter.c
@@ -19,2 +20,2 @@
---- a/app/test/test_event_eth_rx_adapter.c
-+++ b/app/test/test_event_eth_rx_adapter.c
+--- a/test/test/test_event_eth_rx_adapter.c
++++ b/test/test/test_event_eth_rx_adapter.c


More information about the stable mailing list