[dpdk-stable] patch 'net/qede: fix warnings from invalid assert' has been queued to LTS release 18.11.3

Kevin Traynor ktraynor at redhat.com
Fri Aug 23 11:42:52 CEST 2019


Hi,

FYI, your patch has been queued to LTS release 18.11.3

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 08/28/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/549d22e1da0df69e83007a4d64d83dedf4f34607

Thanks.

Kevin Traynor

---
>From 549d22e1da0df69e83007a4d64d83dedf4f34607 Mon Sep 17 00:00:00 2001
From: Stephen Hemminger <stephen at networkplumber.org>
Date: Wed, 19 Jun 2019 11:22:17 -0700
Subject: [PATCH] net/qede: fix warnings from invalid assert
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

[ upstream commit 8db9a3145b9670ccc9030abbc0d20956b2ebb26e ]

This driver had a bogus assert which could never happen.
This triggers "expression is always false warnings" with some
compilers which causes build failure.
Just remove it.

Fixes: 2af14ca79c0a ("net/qede: support 100G")

Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
Acked-by: Rasesh Mody <rmody at marvell.com>
Acked-by: Morten Brørup <mb at smartsharesystems.com>
---
 drivers/net/qede/qede_ethdev.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c
index 0b2f305e1..c4f5ad1ed 100644
--- a/drivers/net/qede/qede_ethdev.c
+++ b/drivers/net/qede/qede_ethdev.c
@@ -1424,5 +1424,4 @@ static void qede_poll_sp_sb_cb(void *param)
 		DP_ERR(edev, "Unable to start periodic"
 			     " timer rc %d\n", rc);
-		assert(false && "Unable to start periodic timer");
 	}
 }
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-08-22 19:38:20.590014956 +0100
+++ 0002-net-qede-fix-warnings-from-invalid-assert.patch	2019-08-22 19:38:20.392027952 +0100
@@ -1 +1 @@
-From 8db9a3145b9670ccc9030abbc0d20956b2ebb26e Mon Sep 17 00:00:00 2001
+From 549d22e1da0df69e83007a4d64d83dedf4f34607 Mon Sep 17 00:00:00 2001
@@ -8,0 +9,2 @@
+[ upstream commit 8db9a3145b9670ccc9030abbc0d20956b2ebb26e ]
+
@@ -15 +16,0 @@
-Cc: stable at dpdk.org
@@ -25 +26 @@
-index 84d898421..82363e6eb 100644
+index 0b2f305e1..c4f5ad1ed 100644
@@ -28 +29 @@
-@@ -1427,5 +1427,4 @@ static void qede_poll_sp_sb_cb(void *param)
+@@ -1424,5 +1424,4 @@ static void qede_poll_sp_sb_cb(void *param)


More information about the stable mailing list