[dpdk-stable] patch 'examples/l3fwd-vf: remove unused Rx/Tx configuration' has been queued to LTS release 18.11.3

Kevin Traynor ktraynor at redhat.com
Fri Aug 23 11:43:18 CEST 2019


Hi,

FYI, your patch has been queued to LTS release 18.11.3

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 08/28/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/2cb7e21e536a941ff49652c25a06e1544993e277

Thanks.

Kevin Traynor

---
>From 2cb7e21e536a941ff49652c25a06e1544993e277 Mon Sep 17 00:00:00 2001
From: Bao-Long Tran <longtb5 at viettel.com.vn>
Date: Mon, 3 Jun 2019 17:06:18 +0700
Subject: [PATCH] examples/l3fwd-vf: remove unused Rx/Tx configuration

[ upstream commit a1d9307b2c0651315fe1a73768a88bacc9c6c59a ]

The RX and TX Prefetch, Host, and Write-back threshold values are
defined but not used anywhere. They are leftovers from a previous
patch.

Fixes: 81f7ecd9 ("examples: use factorized default Rx/Tx configuration")

Signed-off-by: Bao-Long Tran <longtb5 at viettel.com.vn>
---
 examples/l3fwd-vf/main.c | 19 -------------------
 1 file changed, 19 deletions(-)

diff --git a/examples/l3fwd-vf/main.c b/examples/l3fwd-vf/main.c
index 41137f978..036f86854 100644
--- a/examples/l3fwd-vf/main.c
+++ b/examples/l3fwd-vf/main.c
@@ -75,23 +75,4 @@
 				(unsigned)8192)
 
-/*
- * RX and TX Prefetch, Host, and Write-back threshold values should be
- * carefully set for optimal performance. Consult the network
- * controller's datasheet and supporting DPDK documentation for guidance
- * on how these parameters should be set.
- */
-#define RX_PTHRESH 8 /**< Default values of RX prefetch threshold reg. */
-#define RX_HTHRESH 8 /**< Default values of RX host threshold reg. */
-#define RX_WTHRESH 4 /**< Default values of RX write-back threshold reg. */
-
-/*
- * These default values are optimized for use with the Intel(R) 82599 10 GbE
- * Controller and the DPDK ixgbe PMD. Consider using other values for other
- * network controllers and/or network drivers.
- */
-#define TX_PTHRESH 36 /**< Default values of TX prefetch threshold reg. */
-#define TX_HTHRESH 0  /**< Default values of TX host threshold reg. */
-#define TX_WTHRESH 0  /**< Default values of TX write-back threshold reg. */
-
 #define MAX_PKT_BURST 32
 #define BURST_TX_DRAIN_US 100 /* TX drain every ~100us */
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-08-22 19:38:22.281403036 +0100
+++ 0028-examples-l3fwd-vf-remove-unused-Rx-Tx-configuration.patch	2019-08-22 19:38:20.448026617 +0100
@@ -1 +1 @@
-From a1d9307b2c0651315fe1a73768a88bacc9c6c59a Mon Sep 17 00:00:00 2001
+From 2cb7e21e536a941ff49652c25a06e1544993e277 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit a1d9307b2c0651315fe1a73768a88bacc9c6c59a ]
+
@@ -11 +12,0 @@
-Cc: stable at dpdk.org
@@ -19 +20 @@
-index 95948676a..1432f8969 100644
+index 41137f978..036f86854 100644


More information about the stable mailing list