[dpdk-stable] patch 'crypto/openssl: fix free of asymmetric crypto keys' has been queued to LTS release 18.11.3
Kevin Traynor
ktraynor at redhat.com
Wed Aug 28 15:41:37 CEST 2019
Hi,
FYI, your patch has been queued to LTS release 18.11.3
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 09/04/19. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue
This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/78807f9b4ffeec5593f7cdb8189cc58a776f369c
Thanks.
Kevin Traynor
---
>From 78807f9b4ffeec5593f7cdb8189cc58a776f369c Mon Sep 17 00:00:00 2001
From: Arek Kusztal <arkadiuszx.kusztal at intel.com>
Date: Mon, 1 Jul 2019 16:57:25 +0200
Subject: [PATCH] crypto/openssl: fix free of asymmetric crypto keys
[ upstream commit 77411bd6387b28e91eac1702c872712f09c62c4b ]
In case big number need to be freed, data it contains should
also be cleared before especially if it is critical data like
private keys.
Fixes: 3e9d6bd447fb ("crypto/openssl: add RSA and mod asym operations")
Cc: stable at dpdk.org
Signed-off-by: Arek Kusztal <arkadiuszx.kusztal at intel.com>
Acked-by: Fiona Trahe <fiona.trahe at intel.com>
---
drivers/crypto/openssl/rte_openssl_pmd_ops.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/crypto/openssl/rte_openssl_pmd_ops.c b/drivers/crypto/openssl/rte_openssl_pmd_ops.c
index d382476a6..234089c88 100644
--- a/drivers/crypto/openssl/rte_openssl_pmd_ops.c
+++ b/drivers/crypto/openssl/rte_openssl_pmd_ops.c
@@ -912,12 +912,12 @@ static int openssl_set_asym_session_parameters(
break;
err_rsa:
- BN_free(n);
- BN_free(e);
- BN_free(d);
- BN_free(p);
- BN_free(q);
- BN_free(dmp1);
- BN_free(dmq1);
- BN_free(iqmp);
+ BN_clear_free(n);
+ BN_clear_free(e);
+ BN_clear_free(d);
+ BN_clear_free(p);
+ BN_clear_free(q);
+ BN_clear_free(dmp1);
+ BN_clear_free(dmq1);
+ BN_clear_free(iqmp);
return -1;
--
2.20.1
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2019-08-28 14:32:31.839894192 +0100
+++ 0002-crypto-openssl-fix-free-of-asymmetric-crypto-keys.patch 2019-08-28 14:32:31.579958742 +0100
@@ -1 +1 @@
-From 77411bd6387b28e91eac1702c872712f09c62c4b Mon Sep 17 00:00:00 2001
+From 78807f9b4ffeec5593f7cdb8189cc58a776f369c Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 77411bd6387b28e91eac1702c872712f09c62c4b ]
+
@@ -20 +22 @@
-index 40217cf0d..a307c91ec 100644
+index d382476a6..234089c88 100644
@@ -23 +25 @@
-@@ -913,12 +913,12 @@ static int openssl_set_asym_session_parameters(
+@@ -912,12 +912,12 @@ static int openssl_set_asym_session_parameters(
More information about the stable
mailing list