[dpdk-stable] patch 'net/bnxt: fix lock release on getting NVM info' has been queued to LTS release 18.11.3

Kevin Traynor ktraynor at redhat.com
Wed Aug 28 15:42:21 CEST 2019


Hi,

FYI, your patch has been queued to LTS release 18.11.3

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 09/04/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/0ec58c089cd8e143a12095eda1a6a62b15db91d7

Thanks.

Kevin Traynor

---
>From 0ec58c089cd8e143a12095eda1a6a62b15db91d7 Mon Sep 17 00:00:00 2001
From: Kalesh AP <kalesh-anakkur.purayil at broadcom.com>
Date: Thu, 18 Jul 2019 09:06:07 +0530
Subject: [PATCH] net/bnxt: fix lock release on getting NVM info

[ upstream commit 6d91fd2ffeab103b70d8d607691b347d583dba6c ]

HWRM response was parsed after releasing the spinlock.

Fixes: 19e6af01bb36 ("net/bnxt: support get/set EEPROM")

Signed-off-by: Kalesh AP <kalesh-anakkur.purayil at broadcom.com>
Reviewed-by: Somnath Kotur <somnath.kotur at broadcom.com>
---
 drivers/net/bnxt/bnxt_hwrm.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c
index 865b42870..bdcc8ee9b 100644
--- a/drivers/net/bnxt/bnxt_hwrm.c
+++ b/drivers/net/bnxt/bnxt_hwrm.c
@@ -3347,10 +3347,9 @@ int bnxt_hwrm_nvm_get_dir_info(struct bnxt *bp, uint32_t *entries,
 
 	HWRM_CHECK_RESULT();
+
+	*entries = rte_le_to_cpu_32(resp->entries);
+	*length = rte_le_to_cpu_32(resp->entry_length);
+
 	HWRM_UNLOCK();
-
-	if (!rc) {
-		*entries = rte_le_to_cpu_32(resp->entries);
-		*length = rte_le_to_cpu_32(resp->entry_length);
-	}
 	return rc;
 }
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-08-28 14:32:34.523195038 +0100
+++ 0046-net-bnxt-fix-lock-release-on-getting-NVM-info.patch	2019-08-28 14:32:31.710955822 +0100
@@ -1 +1 @@
-From 6d91fd2ffeab103b70d8d607691b347d583dba6c Mon Sep 17 00:00:00 2001
+From 0ec58c089cd8e143a12095eda1a6a62b15db91d7 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 6d91fd2ffeab103b70d8d607691b347d583dba6c ]
+
@@ -9 +10,0 @@
-Cc: stable at dpdk.org
@@ -18 +19 @@
-index 456cc76b8..2e198fcae 100644
+index 865b42870..bdcc8ee9b 100644
@@ -21 +22 @@
-@@ -3575,10 +3575,9 @@ int bnxt_hwrm_nvm_get_dir_info(struct bnxt *bp, uint32_t *entries,
+@@ -3347,10 +3347,9 @@ int bnxt_hwrm_nvm_get_dir_info(struct bnxt *bp, uint32_t *entries,


More information about the stable mailing list