[dpdk-stable] patch 'eal/ppc: fix 64-bit atomic exchange operation' has been queued to LTS release 18.11.6

Kevin Traynor ktraynor at redhat.com
Tue Dec 3 19:26:50 CET 2019


Hi,

FYI, your patch has been queued to LTS release 18.11.6

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 12/10/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/0d9b7efa224a3d5d8d4338ee8cb479f2225091e1

Thanks.

Kevin.

---
>From 0d9b7efa224a3d5d8d4338ee8cb479f2225091e1 Mon Sep 17 00:00:00 2001
From: David Christensen <drc at linux.vnet.ibm.com>
Date: Tue, 15 Oct 2019 14:16:14 -0700
Subject: [PATCH] eal/ppc: fix 64-bit atomic exchange operation

[ upstream commit 72e69d801b235f40b6c71a7d4f6087e2fa5b02dc ]

The rte_atomic64_exchange operation for ppc_64 incorrectly linked
back to a 32 bit generic operation (__atomic_exchange_4) rather than
the 64 bit generic operation (__atomic_exchange_8).  As a result,
applications that used rte_eth_link_get_nowait() would only receive
the link speed, they would not receive the link state, link duplex,
or link autoneg properties.

Fixes: ff2863570fcc ("eal: introduce atomic exchange operation")

Signed-off-by: David Christensen <drc at linux.vnet.ibm.com>
Reviewed-by: David Marchand <david.marchand at redhat.com>
---
 lib/librte_eal/common/include/arch/ppc_64/rte_atomic.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_eal/common/include/arch/ppc_64/rte_atomic.h b/lib/librte_eal/common/include/arch/ppc_64/rte_atomic.h
index 797381c0f..afcb8ee3a 100644
--- a/lib/librte_eal/common/include/arch/ppc_64/rte_atomic.h
+++ b/lib/librte_eal/common/include/arch/ppc_64/rte_atomic.h
@@ -451,5 +451,5 @@ static inline uint64_t
 rte_atomic64_exchange(volatile uint64_t *dst, uint64_t val)
 {
-	return __atomic_exchange_4(dst, val, __ATOMIC_SEQ_CST);
+	return __atomic_exchange_8(dst, val, __ATOMIC_SEQ_CST);
 }
 
-- 
2.21.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-12-03 17:29:54.181276072 +0000
+++ 0041-eal-ppc-fix-64-bit-atomic-exchange-operation.patch	2019-12-03 17:29:51.765749641 +0000
@@ -1 +1 @@
-From 72e69d801b235f40b6c71a7d4f6087e2fa5b02dc Mon Sep 17 00:00:00 2001
+From 0d9b7efa224a3d5d8d4338ee8cb479f2225091e1 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 72e69d801b235f40b6c71a7d4f6087e2fa5b02dc ]
+
@@ -14 +15,0 @@
-Cc: stable at dpdk.org
@@ -23 +24 @@
-index b13a80de4..7e3e13118 100644
+index 797381c0f..afcb8ee3a 100644
@@ -26 +27 @@
-@@ -402,5 +402,5 @@ static inline uint64_t
+@@ -451,5 +451,5 @@ static inline uint64_t



More information about the stable mailing list