[dpdk-stable] patch 'ethdev: fix item expansion for RSS flow' has been queued to LTS release 18.11.6

[Kevin Traynor]

Hi,

FYI, your patch has been queued to LTS release 18.11.6

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 12/17/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/a9228f7067852d691a4425d3237cab77af5d34fa

Thanks.

Kevin.

---
>From a9228f7067852d691a4425d3237cab77af5d34fa Mon Sep 17 00:00:00 2001
From: Matan Azrad <matan at mellanox.com>
Date: Tue, 26 Nov 2019 09:04:10 +0000
Subject: [PATCH] ethdev: fix item expansion for RSS flow

[ upstream commit 64edb05e29c82260a0bd1000a20023d20c123e41 ]

When the last item in flow pattern includes "next protocol" field which
is relevant for RSS flow expansion, a new item is added to the pattern
according to the "next protocol" field. This field is called missed
field.

The missed field wrongly was not initialized what caused to some of the
flow item fields to contain garbage values.

As a result, the PMDs internal flow engine may crash.

For example, the spec value may include garbage pointer and to cause
crash.

Initialize the missed field with zeroes.

Fixes: fc2dd8dd492f ("ethdev: fix expand RSS flows")

Signed-off-by: Matan Azrad <matan at mellanox.com>
Acked-by: Ori Kam <orika at mellanox.com>
---
 lib/librte_ethdev/rte_flow.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/librte_ethdev/rte_flow.c b/lib/librte_ethdev/rte_flow.c
index d545b15f5..5725aceda 100644
--- a/lib/librte_ethdev/rte_flow.c
+++ b/lib/librte_ethdev/rte_flow.c
@@ -984,4 +984,5 @@ rte_flow_expand_rss(struct rte_flow_expand_rss *buf, size_t size,
 	const struct rte_flow_item *last_item = NULL;
 
+	memset(&missed_item, 0, sizeof(missed_item));
 	lsize = offsetof(struct rte_flow_expand_rss, entry) +
 		elt_n * sizeof(buf->entry[0]);
-- 
2.21.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-12-11 21:24:13.971759304 +0000
+++ 0015-ethdev-fix-item-expansion-for-RSS-flow.patch	2019-12-11 21:24:12.598652643 +0000
@@ -1 +1 @@
-From 64edb05e29c82260a0bd1000a20023d20c123e41 Mon Sep 17 00:00:00 2001
+From a9228f7067852d691a4425d3237cab77af5d34fa Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 64edb05e29c82260a0bd1000a20023d20c123e41 ]
+
@@ -22 +23,0 @@
-Cc: stable at dpdk.org
@@ -31 +32 @@
-index d7f29e532..87a3e8c4c 100644
+index d545b15f5..5725aceda 100644
@@ -34 +35 @@
-@@ -1072,4 +1072,5 @@ rte_flow_expand_rss(struct rte_flow_expand_rss *buf, size_t size,
+@@ -984,4 +984,5 @@ rte_flow_expand_rss(struct rte_flow_expand_rss *buf, size_t size,