[dpdk-stable] patch 'net/enic: re-enable link status change interrupt' has been queued to LTS release 18.11.6
Kevin Traynor
ktraynor at redhat.com
Wed Dec 11 22:26:11 CET 2019
Hi,
FYI, your patch has been queued to LTS release 18.11.6
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 12/17/19. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue
This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/759a205e118e731dc5e3cb209f3716fd4f8a45d3
Thanks.
Kevin.
---
>From 759a205e118e731dc5e3cb209f3716fd4f8a45d3 Mon Sep 17 00:00:00 2001
From: Hyong Youb Kim <hyonkim at cisco.com>
Date: Thu, 7 Nov 2019 06:42:24 -0800
Subject: [PATCH] net/enic: re-enable link status change interrupt
[ upstream commit 8bac78f8262e2c4d8d72bf7e77c2d55b62b844f2 ]
When INTx is used, the interrupt handler needs to explicitly re-enable
interrupt in order to receive another one in future. The LSC interrupt
handler currently does not, and the link state never gets updated when
INTx is used (e.g. uio_pci_generic). Call rte_intr_ack() at the end of
the handler, to re-enable INTx.
Fixes: fefed3d1e62c ("enic: new driver")
Signed-off-by: Hyong Youb Kim <hyonkim at cisco.com>
Reviewed-by: John Daley <johndale at cisco.com>
---
drivers/net/enic/Makefile | 2 ++
drivers/net/enic/enic_main.c | 2 ++
drivers/net/enic/meson.build | 2 ++
3 files changed, 6 insertions(+)
diff --git a/drivers/net/enic/Makefile b/drivers/net/enic/Makefile
index e39e47631..a101d0fe0 100644
--- a/drivers/net/enic/Makefile
+++ b/drivers/net/enic/Makefile
@@ -14,4 +14,6 @@ EXPORT_MAP := rte_pmd_enic_version.map
LIBABIVER := 1
+# Experimental APIs used: rte_intr_ack
+CFLAGS += -DALLOW_EXPERIMENTAL_API
CFLAGS += -I$(SRCDIR)/base/
CFLAGS += -I$(SRCDIR)
diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c
index c3dc3dee1..6b3b0867d 100644
--- a/drivers/net/enic/enic_main.c
+++ b/drivers/net/enic/enic_main.c
@@ -442,4 +442,6 @@ enic_intr_handler(void *arg)
_rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_LSC, NULL);
enic_log_q_error(enic);
+ /* Re-enable irq in case of INTx */
+ rte_intr_ack(&enic->pdev->intr_handle);
}
diff --git a/drivers/net/enic/meson.build b/drivers/net/enic/meson.build
index 9e9a567ae..4a4d2d654 100644
--- a/drivers/net/enic/meson.build
+++ b/drivers/net/enic/meson.build
@@ -2,4 +2,6 @@
# Copyright(c) 2018 Cisco Systems, Inc.
+# Experimental APIs used: rte_intr_ack
+cflags += ['-DALLOW_EXPERIMENTAL_API']
sources = files(
'base/vnic_cq.c',
--
2.21.0
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2019-12-11 21:24:14.253917793 +0000
+++ 0019-net-enic-re-enable-link-status-change-interrupt.patch 2019-12-11 21:24:12.610652395 +0000
@@ -1 +1 @@
-From 8bac78f8262e2c4d8d72bf7e77c2d55b62b844f2 Mon Sep 17 00:00:00 2001
+From 759a205e118e731dc5e3cb209f3716fd4f8a45d3 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 8bac78f8262e2c4d8d72bf7e77c2d55b62b844f2 ]
+
@@ -13 +14,0 @@
-Cc: stable at dpdk.org
@@ -24 +25 @@
-index 10736a567..4e0c83da5 100644
+index e39e47631..a101d0fe0 100644
@@ -35 +36 @@
-index f5b9b0dcb..57574a5f7 100644
+index c3dc3dee1..6b3b0867d 100644
@@ -38 +39 @@
-@@ -449,4 +449,6 @@ enic_intr_handler(void *arg)
+@@ -442,4 +442,6 @@ enic_intr_handler(void *arg)
@@ -46 +47 @@
-index 1bd7cc7e1..e5eeb5667 100644
+index 9e9a567ae..4a4d2d654 100644
More information about the stable
mailing list