[dpdk-stable] patch 'net/bonding: fix unicast packets filtering' has been queued to LTS release 17.11.10

luca.boccassi at gmail.com luca.boccassi at gmail.com
Thu Dec 19 15:32:29 CET 2019


Hi,

FYI, your patch has been queued to LTS release 17.11.10

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 12/21/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Luca Boccassi

---
>From 8c0875f69b6294bf958212f9895a51583b154775 Mon Sep 17 00:00:00 2001
From: David Marchand <david.marchand at redhat.com>
Date: Wed, 10 Apr 2019 14:53:48 +0200
Subject: [PATCH] net/bonding: fix unicast packets filtering

[ upstream commit 0ec234460b9282c96033282a9679e88d2df5e58e ]

By default, the 802.3ad code enables promisc mode on all slaves.
To avoid all packets going to the application (unless the application
asked for promiscuous mode), all frames are supposed to be filtered in
the rx burst handler.

However the incriminated commit broke this because non pure ethernet
frames (basically any unicast Ether()/IP() packet) are not filtered
anymore.

Fixes: 71b7b37ec959 ("net/bonding: use ptype flags for LACP Rx filtering")

Signed-off-by: David Marchand <david.marchand at redhat.com>
Acked-by: Chas Williams <chas3 at att.com>
---
 drivers/net/bonding/rte_eth_bond_pmd.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c
index 4de62bcf50..e2487e5f71 100644
--- a/drivers/net/bonding/rte_eth_bond_pmd.c
+++ b/drivers/net/bonding/rte_eth_bond_pmd.c
@@ -415,13 +415,6 @@ rx_burst_8023ad(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts,
 
 		/* Handle slow protocol packets. */
 		while (j < num_rx_total) {
-
-			/* If packet is not pure L2 and is known, skip it */
-			if ((bufs[j]->packet_type & ~RTE_PTYPE_L2_ETHER) != 0) {
-				j++;
-				continue;
-			}
-
 			if (j + 3 < num_rx_total)
 				rte_prefetch0(rte_pktmbuf_mtod(bufs[j + 3], void *));
 
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-12-19 14:32:26.431110610 +0000
+++ 0002-net-bonding-fix-unicast-packets-filtering.patch	2019-12-19 14:32:25.385283548 +0000
@@ -1,8 +1,10 @@
-From 0ec234460b9282c96033282a9679e88d2df5e58e Mon Sep 17 00:00:00 2001
+From 8c0875f69b6294bf958212f9895a51583b154775 Mon Sep 17 00:00:00 2001
 From: David Marchand <david.marchand at redhat.com>
 Date: Wed, 10 Apr 2019 14:53:48 +0200
 Subject: [PATCH] net/bonding: fix unicast packets filtering
 
+[ upstream commit 0ec234460b9282c96033282a9679e88d2df5e58e ]
+
 By default, the 802.3ad code enables promisc mode on all slaves.
 To avoid all packets going to the application (unless the application
 asked for promiscuous mode), all frames are supposed to be filtered in
@@ -13,7 +15,6 @@
 anymore.
 
 Fixes: 71b7b37ec959 ("net/bonding: use ptype flags for LACP Rx filtering")
-Cc: stable at dpdk.org
 
 Signed-off-by: David Marchand <david.marchand at redhat.com>
 Acked-by: Chas Williams <chas3 at att.com>
@@ -22,10 +23,10 @@
  1 file changed, 7 deletions(-)
 
 diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c
-index 44af5ade17..49e38f6b17 100644
+index 4de62bcf50..e2487e5f71 100644
 --- a/drivers/net/bonding/rte_eth_bond_pmd.c
 +++ b/drivers/net/bonding/rte_eth_bond_pmd.c
-@@ -304,13 +304,6 @@ rx_burst_8023ad(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts,
+@@ -415,13 +415,6 @@ rx_burst_8023ad(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts,
  
  		/* Handle slow protocol packets. */
  		while (j < num_rx_total) {


More information about the stable mailing list