[dpdk-stable] patch 'drivers/crypto: remove some invalid comments' has been queued to LTS release 17.11.10
luca.boccassi at gmail.com
luca.boccassi at gmail.com
Thu Dec 19 15:32:50 CET 2019
Hi,
FYI, your patch has been queued to LTS release 17.11.10
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 12/21/19. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Thanks.
Luca Boccassi
---
>From 04e0d96e4b6b519e5cdd919b3f23e2cfc3e59794 Mon Sep 17 00:00:00 2001
From: Thierry Herbelot <thierry.herbelot at 6wind.com>
Date: Mon, 30 Sep 2019 09:51:44 +0200
Subject: [PATCH] drivers/crypto: remove some invalid comments
[ upstream commit 310d2ea6328c6146ccca6eac42426e060a99fedc ]
A comment valid in AESNI PMD was copied and pasted in other code
Fixes: 8a61c83af2fa ("crypto/mrvl: add mrvl crypto driver")
Fixes: 169ca3db550c ("crypto/armv8: add PMD optimized for ARMv8 processors")
Fixes: d61f70b4c918 ("crypto/libcrypto: add driver for OpenSSL library")
Signed-off-by: Thierry Herbelot <thierry.herbelot at 6wind.com>
Acked-by: Akhil Goyal <akhil.goyal at nxp.com>
---
drivers/crypto/armv8/rte_armv8_pmd.c | 1 -
drivers/crypto/mrvl/rte_mrvl_pmd.c | 1 -
drivers/crypto/openssl/rte_openssl_pmd.c | 1 -
3 files changed, 3 deletions(-)
diff --git a/drivers/crypto/armv8/rte_armv8_pmd.c b/drivers/crypto/armv8/rte_armv8_pmd.c
index 97719f278e..d757ebfe70 100644
--- a/drivers/crypto/armv8/rte_armv8_pmd.c
+++ b/drivers/crypto/armv8/rte_armv8_pmd.c
@@ -803,7 +803,6 @@ cryptodev_armv8_crypto_create(const char *name,
RTE_CRYPTODEV_FF_CPU_NEON |
RTE_CRYPTODEV_FF_CPU_ARM_CE;
- /* Set vector instructions mode supported */
internals = dev->data->dev_private;
internals->max_nb_qpairs = init_params->max_nb_queue_pairs;
diff --git a/drivers/crypto/mrvl/rte_mrvl_pmd.c b/drivers/crypto/mrvl/rte_mrvl_pmd.c
index 31f3fe581e..95276a9467 100644
--- a/drivers/crypto/mrvl/rte_mrvl_pmd.c
+++ b/drivers/crypto/mrvl/rte_mrvl_pmd.c
@@ -743,7 +743,6 @@ cryptodev_mrvl_crypto_create(const char *name,
RTE_CRYPTODEV_FF_SYM_OPERATION_CHAINING |
RTE_CRYPTODEV_FF_HW_ACCELERATED;
- /* Set vector instructions mode supported */
internals = dev->data->dev_private;
internals->max_nb_qpairs = init_params->max_nb_queue_pairs;
diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c b/drivers/crypto/openssl/rte_openssl_pmd.c
index 06e1a6defc..7b18bd42e7 100644
--- a/drivers/crypto/openssl/rte_openssl_pmd.c
+++ b/drivers/crypto/openssl/rte_openssl_pmd.c
@@ -1690,7 +1690,6 @@ cryptodev_openssl_create(const char *name,
RTE_CRYPTODEV_FF_CPU_AESNI |
RTE_CRYPTODEV_FF_MBUF_SCATTER_GATHER;
- /* Set vector instructions mode supported */
internals = dev->data->dev_private;
internals->max_nb_qpairs = init_params->max_nb_queue_pairs;
--
2.20.1
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2019-12-19 14:32:27.235344013 +0000
+++ 0023-drivers-crypto-remove-some-invalid-comments.patch 2019-12-19 14:32:25.573287276 +0000
@@ -1,28 +1,29 @@
-From 310d2ea6328c6146ccca6eac42426e060a99fedc Mon Sep 17 00:00:00 2001
+From 04e0d96e4b6b519e5cdd919b3f23e2cfc3e59794 Mon Sep 17 00:00:00 2001
From: Thierry Herbelot <thierry.herbelot at 6wind.com>
Date: Mon, 30 Sep 2019 09:51:44 +0200
Subject: [PATCH] drivers/crypto: remove some invalid comments
+[ upstream commit 310d2ea6328c6146ccca6eac42426e060a99fedc ]
+
A comment valid in AESNI PMD was copied and pasted in other code
Fixes: 8a61c83af2fa ("crypto/mrvl: add mrvl crypto driver")
Fixes: 169ca3db550c ("crypto/armv8: add PMD optimized for ARMv8 processors")
Fixes: d61f70b4c918 ("crypto/libcrypto: add driver for OpenSSL library")
-Cc: stable at dpdk.org
Signed-off-by: Thierry Herbelot <thierry.herbelot at 6wind.com>
Acked-by: Akhil Goyal <akhil.goyal at nxp.com>
---
drivers/crypto/armv8/rte_armv8_pmd.c | 1 -
- drivers/crypto/mvsam/rte_mrvl_pmd.c | 1 -
+ drivers/crypto/mrvl/rte_mrvl_pmd.c | 1 -
drivers/crypto/openssl/rte_openssl_pmd.c | 1 -
3 files changed, 3 deletions(-)
diff --git a/drivers/crypto/armv8/rte_armv8_pmd.c b/drivers/crypto/armv8/rte_armv8_pmd.c
-index 0d4649adcd..711701a974 100644
+index 97719f278e..d757ebfe70 100644
--- a/drivers/crypto/armv8/rte_armv8_pmd.c
+++ b/drivers/crypto/armv8/rte_armv8_pmd.c
-@@ -777,7 +777,6 @@ cryptodev_armv8_crypto_create(const char *name,
+@@ -803,7 +803,6 @@ cryptodev_armv8_crypto_create(const char *name,
RTE_CRYPTODEV_FF_CPU_NEON |
RTE_CRYPTODEV_FF_CPU_ARM_CE;
@@ -30,25 +31,25 @@
internals = dev->data->dev_private;
internals->max_nb_qpairs = init_params->max_nb_queue_pairs;
-diff --git a/drivers/crypto/mvsam/rte_mrvl_pmd.c b/drivers/crypto/mvsam/rte_mrvl_pmd.c
-index ef2e5ed00d..0aafcc1503 100644
---- a/drivers/crypto/mvsam/rte_mrvl_pmd.c
-+++ b/drivers/crypto/mvsam/rte_mrvl_pmd.c
-@@ -821,7 +821,6 @@ cryptodev_mrvl_crypto_create(const char *name,
- RTE_CRYPTODEV_FF_OOP_SGL_IN_LB_OUT |
- RTE_CRYPTODEV_FF_OOP_LB_IN_LB_OUT;
+diff --git a/drivers/crypto/mrvl/rte_mrvl_pmd.c b/drivers/crypto/mrvl/rte_mrvl_pmd.c
+index 31f3fe581e..95276a9467 100644
+--- a/drivers/crypto/mrvl/rte_mrvl_pmd.c
++++ b/drivers/crypto/mrvl/rte_mrvl_pmd.c
+@@ -743,7 +743,6 @@ cryptodev_mrvl_crypto_create(const char *name,
+ RTE_CRYPTODEV_FF_SYM_OPERATION_CHAINING |
+ RTE_CRYPTODEV_FF_HW_ACCELERATED;
- /* Set vector instructions mode supported */
internals = dev->data->dev_private;
- internals->max_nb_qpairs = init_params->common.max_nb_queue_pairs;
+ internals->max_nb_qpairs = init_params->max_nb_queue_pairs;
diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c b/drivers/crypto/openssl/rte_openssl_pmd.c
-index 2f55528407..b05f6adb92 100644
+index 06e1a6defc..7b18bd42e7 100644
--- a/drivers/crypto/openssl/rte_openssl_pmd.c
+++ b/drivers/crypto/openssl/rte_openssl_pmd.c
-@@ -2127,7 +2127,6 @@ cryptodev_openssl_create(const char *name,
- RTE_CRYPTODEV_FF_RSA_PRIV_OP_KEY_EXP |
- RTE_CRYPTODEV_FF_RSA_PRIV_OP_KEY_QT;
+@@ -1690,7 +1690,6 @@ cryptodev_openssl_create(const char *name,
+ RTE_CRYPTODEV_FF_CPU_AESNI |
+ RTE_CRYPTODEV_FF_MBUF_SCATTER_GATHER;
- /* Set vector instructions mode supported */
internals = dev->data->dev_private;
More information about the stable
mailing list