[dpdk-stable] patch 'net/vhost: fix redundant queue state event' has been queued to LTS release 17.11.10

[luca.boccassi at gmail.com]

Hi,

FYI, your patch has been queued to LTS release 17.11.10

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 12/21/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Luca Boccassi

---
>From fb36c3728ea5174c45d180b50dca85c07ef864a6 Mon Sep 17 00:00:00 2001
From: Noa Ezra <noae at mellanox.com>
Date: Thu, 20 Jun 2019 06:33:03 +0000
Subject: [PATCH] net/vhost: fix redundant queue state event

[ upstream commit f2f0577eff3d13e761996c7390a244963b433bdc ]

In some situations, when a virtual machine is starting,
vring_state_changed can be called while there was no change in the
queue state. This fix makes sure that there was really a change in the
queue state before calling the callback for EVENT_QUEUE_STATE.

Fixes: ee584e9710b9 ("vhost: add driver on top of the library")

Signed-off-by: Noa Ezra <noae at mellanox.com>
Reviewed-by: Matan Azrad <matan at mellanox.com>
Reviewed-by: Maxime Coquelin <maxime.coquelin at redhat.com>
---
 drivers/net/vhost/rte_eth_vhost.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c
index 7b7780c9c4..1f3b271743 100644
--- a/drivers/net/vhost/rte_eth_vhost.c
+++ b/drivers/net/vhost/rte_eth_vhost.c
@@ -705,6 +705,10 @@ vring_state_changed(int vid, uint16_t vring, int enable)
 	/* won't be NULL */
 	state = vring_states[eth_dev->data->port_id];
 	rte_spinlock_lock(&state->lock);
+	if (state->cur[vring] == enable) {
+		rte_spinlock_unlock(&state->lock);
+		return 0;
+	}
 	state->cur[vring] = enable;
 	state->max_vring = RTE_MAX(vring, state->max_vring);
 	rte_spinlock_unlock(&state->lock);
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-12-19 14:32:27.661772986 +0000
+++ 0033-net-vhost-fix-redundant-queue-state-event.patch	2019-12-19 14:32:25.797291718 +0000
@@ -1,15 +1,16 @@
-From f2f0577eff3d13e761996c7390a244963b433bdc Mon Sep 17 00:00:00 2001
+From fb36c3728ea5174c45d180b50dca85c07ef864a6 Mon Sep 17 00:00:00 2001
 From: Noa Ezra <noae at mellanox.com>
 Date: Thu, 20 Jun 2019 06:33:03 +0000
 Subject: [PATCH] net/vhost: fix redundant queue state event
 
+[ upstream commit f2f0577eff3d13e761996c7390a244963b433bdc ]
+
 In some situations, when a virtual machine is starting,
 vring_state_changed can be called while there was no change in the
 queue state. This fix makes sure that there was really a change in the
 queue state before calling the callback for EVENT_QUEUE_STATE.
 
 Fixes: ee584e9710b9 ("vhost: add driver on top of the library")
-Cc: stable at dpdk.org
 
 Signed-off-by: Noa Ezra <noae at mellanox.com>
 Reviewed-by: Matan Azrad <matan at mellanox.com>
@@ -19,10 +20,10 @@
  1 file changed, 4 insertions(+)
 
 diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c
-index c3ba602767..5de21f1434 100644
+index 7b7780c9c4..1f3b271743 100644
 --- a/drivers/net/vhost/rte_eth_vhost.c
 +++ b/drivers/net/vhost/rte_eth_vhost.c
-@@ -853,6 +853,10 @@ vring_state_changed(int vid, uint16_t vring, int enable)
+@@ -705,6 +705,10 @@ vring_state_changed(int vid, uint16_t vring, int enable)
  	/* won't be NULL */
  	state = vring_states[eth_dev->data->port_id];
  	rte_spinlock_lock(&state->lock);