[dpdk-stable] patch 'net/ixgbe: fix address of first segment' has been queued to LTS release 17.11.10

luca.boccassi at gmail.com luca.boccassi at gmail.com
Thu Dec 19 15:33:41 CET 2019


Hi,

FYI, your patch has been queued to LTS release 17.11.10

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 12/21/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Luca Boccassi

---
>From e2d7c98653f151eaa64964352f7e3fde22b35065 Mon Sep 17 00:00:00 2001
From: Joyce Kong <joyce.kong at arm.com>
Date: Tue, 24 Sep 2019 13:48:45 +0800
Subject: [PATCH] net/ixgbe: fix address of first segment

[ upstream commit 648255d43e4a820274cbb02cca3ece445d8de302 ]

This patch fixes (dereference after null check) coverity issue.
The address of first segmented packets was not set correctly during
reassembling packets which led to this issue.

Coverity issue: 13245
Fixes: 8a44c15aa57d ("net/ixgbe: extract non-x86 specific code from vector driver")

Signed-off-by: Joyce Kong <joyce.kong at arm.com>
Reviewed-by: Xiao Zhang <xiao.zhang at intel.com>
Reviewed-by: Xiaolong Ye <xiaolong.ye at intel.com>
---
 drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c b/drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c
index 4d7726f406..0b38d97fa0 100644
--- a/drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c
+++ b/drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c
@@ -403,6 +403,7 @@ ixgbe_recv_scattered_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,
 			i++;
 		if (i == nb_bufs)
 			return nb_bufs;
+		rxq->pkt_first_seg = rx_pkts[i];
 	}
 	return i + reassemble_packets(rxq, &rx_pkts[i], nb_bufs - i,
 		&split_flags[i]);
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-12-19 14:32:29.261099526 +0000
+++ 0074-net-ixgbe-fix-address-of-first-segment.patch	2019-12-19 14:32:26.165299015 +0000
@@ -1,15 +1,16 @@
-From 648255d43e4a820274cbb02cca3ece445d8de302 Mon Sep 17 00:00:00 2001
+From e2d7c98653f151eaa64964352f7e3fde22b35065 Mon Sep 17 00:00:00 2001
 From: Joyce Kong <joyce.kong at arm.com>
 Date: Tue, 24 Sep 2019 13:48:45 +0800
 Subject: [PATCH] net/ixgbe: fix address of first segment
 
+[ upstream commit 648255d43e4a820274cbb02cca3ece445d8de302 ]
+
 This patch fixes (dereference after null check) coverity issue.
 The address of first segmented packets was not set correctly during
 reassembling packets which led to this issue.
 
 Coverity issue: 13245
 Fixes: 8a44c15aa57d ("net/ixgbe: extract non-x86 specific code from vector driver")
-Cc: stable at dpdk.org
 
 Signed-off-by: Joyce Kong <joyce.kong at arm.com>
 Reviewed-by: Xiao Zhang <xiao.zhang at intel.com>
@@ -19,10 +20,10 @@
  1 file changed, 1 insertion(+)
 
 diff --git a/drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c b/drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c
-index eeb825911c..26c0ef5aec 100644
+index 4d7726f406..0b38d97fa0 100644
 --- a/drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c
 +++ b/drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c
-@@ -375,6 +375,7 @@ ixgbe_recv_scattered_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,
+@@ -403,6 +403,7 @@ ixgbe_recv_scattered_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,
  			i++;
  		if (i == nb_bufs)
  			return nb_bufs;


More information about the stable mailing list