[dpdk-stable] patch 'net/sfc: fix adapter lock usage on rule creation' has been queued to LTS release 17.11.10

[luca.boccassi at gmail.com]

Hi,

FYI, your patch has been queued to LTS release 17.11.10

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 12/21/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Luca Boccassi

---
>From 54bbd54fd2eacadb328e1286015ecf8706400eaf Mon Sep 17 00:00:00 2001
From: Ivan Malov <ivan.malov at oktetlabs.ru>
Date: Sun, 3 Nov 2019 13:33:09 +0300
Subject: [PATCH] net/sfc: fix adapter lock usage on rule creation

[ upstream commit 653b285ff11380c44c96a92bedf08fe1614a2fdc ]

The point is that adapter lock has to be held on
list accesses, as well as when talking to the HW.

Fixes: a9825ccf5bb8 ("net/sfc: support flow API filters")

Signed-off-by: Ivan Malov <ivan.malov at oktetlabs.ru>
Signed-off-by: Andrew Rybchenko <arybchenko at solarflare.com>
---
 drivers/net/sfc/sfc_flow.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/sfc/sfc_flow.c b/drivers/net/sfc/sfc_flow.c
index 90ef5bf204..9d46abeb6f 100644
--- a/drivers/net/sfc/sfc_flow.c
+++ b/drivers/net/sfc/sfc_flow.c
@@ -1185,10 +1185,10 @@ sfc_flow_create(struct rte_eth_dev *dev,
 	if (rc != 0)
 		goto fail_bad_value;
 
+	sfc_adapter_lock(sa);
+
 	TAILQ_INSERT_TAIL(&sa->filter.flow_list, flow, entries);
 
-	sfc_adapter_lock(sa);
-
 	if (sa->state == SFC_ADAPTER_STARTED) {
 		rc = sfc_flow_filter_insert(sa, flow);
 		if (rc != 0) {
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-12-19 14:32:30.943652508 +0000
+++ 0116-net-sfc-fix-adapter-lock-usage-on-rule-creation.patch	2019-12-19 14:32:26.293301553 +0000
@@ -1,13 +1,14 @@
-From 653b285ff11380c44c96a92bedf08fe1614a2fdc Mon Sep 17 00:00:00 2001
+From 54bbd54fd2eacadb328e1286015ecf8706400eaf Mon Sep 17 00:00:00 2001
 From: Ivan Malov <ivan.malov at oktetlabs.ru>
 Date: Sun, 3 Nov 2019 13:33:09 +0300
 Subject: [PATCH] net/sfc: fix adapter lock usage on rule creation
 
+[ upstream commit 653b285ff11380c44c96a92bedf08fe1614a2fdc ]
+
 The point is that adapter lock has to be held on
 list accesses, as well as when talking to the HW.
 
 Fixes: a9825ccf5bb8 ("net/sfc: support flow API filters")
-Cc: stable at dpdk.org
 
 Signed-off-by: Ivan Malov <ivan.malov at oktetlabs.ru>
 Signed-off-by: Andrew Rybchenko <arybchenko at solarflare.com>
@@ -16,10 +17,10 @@
  1 file changed, 2 insertions(+), 2 deletions(-)
 
 diff --git a/drivers/net/sfc/sfc_flow.c b/drivers/net/sfc/sfc_flow.c
-index e4a9ba0ff9..8d636f6923 100644
+index 90ef5bf204..9d46abeb6f 100644
 --- a/drivers/net/sfc/sfc_flow.c
 +++ b/drivers/net/sfc/sfc_flow.c
-@@ -2315,10 +2315,10 @@ sfc_flow_create(struct rte_eth_dev *dev,
+@@ -1185,10 +1185,10 @@ sfc_flow_create(struct rte_eth_dev *dev,
  	if (rc != 0)
  		goto fail_bad_value;