[dpdk-stable] patch 'test/metrics: fix a negative case' has been queued to LTS release 18.11.1
Kevin Traynor
ktraynor at redhat.com
Thu Feb 7 14:25:48 CET 2019
Hi,
FYI, your patch has been queued to LTS release 18.11.1
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/14/19. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Thanks.
Kevin Traynor
---
>From 6423daae9b4b22ec966d702ab83a556968e01ea9 Mon Sep 17 00:00:00 2001
From: Harman Kalra <hkalra at marvell.com>
Date: Mon, 10 Dec 2018 08:39:15 +0000
Subject: [PATCH] test/metrics: fix a negative case
[ upstream commit 99f16073b2a3d9881aa8fabe24c62834d902afda ]
Negative test case for passing invalid count size to
rte_metrics_update_values() will pass if count value
is any value greater than 1 because set size wrt to
key id 1 is 1 and passing 0 as no of values to be
updated will not hit the ERANGE check.
Fixes: cd3804242901 ("test/metrics: add unit tests for metrics library")
Signed-off-by: Harman Kalra <hkalra at marvell.com>
Acked-by: Remy Horton <remy.horton at intel.com>
---
test/test/test_metrics.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/test/test_metrics.c b/test/test/test_metrics.c
index 94d54d71c..3c2f36b8a 100644
--- a/test/test/test_metrics.c
+++ b/test/test/test_metrics.c
@@ -155,5 +155,5 @@ test_metrics_update_values(void)
/* Failed Test: Invalid count size */
err = rte_metrics_update_values(RTE_METRICS_GLOBAL,
- KEY, &value[0], 0);
+ KEY, &value[0], ARRAY_SIZE(value));
TEST_ASSERT(err < 0, "%s, %d", __func__, __LINE__);
--
2.19.0
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2019-02-07 13:19:56.524208234 +0000
+++ 0042-test-metrics-fix-a-negative-case.patch 2019-02-07 13:19:55.000000000 +0000
@@ -1,8 +1,10 @@
-From 99f16073b2a3d9881aa8fabe24c62834d902afda Mon Sep 17 00:00:00 2001
+From 6423daae9b4b22ec966d702ab83a556968e01ea9 Mon Sep 17 00:00:00 2001
From: Harman Kalra <hkalra at marvell.com>
Date: Mon, 10 Dec 2018 08:39:15 +0000
Subject: [PATCH] test/metrics: fix a negative case
+[ upstream commit 99f16073b2a3d9881aa8fabe24c62834d902afda ]
+
Negative test case for passing invalid count size to
rte_metrics_update_values() will pass if count value
is any value greater than 1 because set size wrt to
@@ -10,7 +12,6 @@
updated will not hit the ERANGE check.
Fixes: cd3804242901 ("test/metrics: add unit tests for metrics library")
-Cc: stable at dpdk.org
Signed-off-by: Harman Kalra <hkalra at marvell.com>
Acked-by: Remy Horton <remy.horton at intel.com>
More information about the stable
mailing list