[dpdk-stable] patch 'ethdev: fix errno to have positive value' has been queued to LTS release 18.11.1

Kevin Traynor ktraynor at redhat.com
Thu Feb 7 14:25:50 CET 2019


Hi,

FYI, your patch has been queued to LTS release 18.11.1

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/14/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Kevin Traynor

---
>From 9d0084878cf266f5c083ef5a4d6276840e2c7ba5 Mon Sep 17 00:00:00 2001
From: Andrew Rybchenko <arybchenko at solarflare.com>
Date: Mon, 21 Jan 2019 16:18:35 +0000
Subject: [PATCH] ethdev: fix errno to have positive value

[ upstream commit 8e0c8dcf3507ae812f1abcd5247617917f131dae ]

rte_errno should be set to positive value from errno.h plus
few RTE-specific values.

Fixes: 4fb7e803eb1a ("ethdev: add Tx preparation")
Fixes: 439a90b5f2a7 ("ethdev: reorder inline functions")

Signed-off-by: Andrew Rybchenko <arybchenko at solarflare.com>
---
 lib/librte_ethdev/rte_ethdev.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h
index 1960f3a2d..a3e9fb816 100644
--- a/lib/librte_ethdev/rte_ethdev.h
+++ b/lib/librte_ethdev/rte_ethdev.h
@@ -4226,5 +4226,5 @@ rte_eth_tx_prepare(uint16_t port_id, uint16_t queue_id,
 	if (!rte_eth_dev_is_valid_port(port_id)) {
 		RTE_ETHDEV_LOG(ERR, "Invalid TX port_id=%u\n", port_id);
-		rte_errno = -EINVAL;
+		rte_errno = EINVAL;
 		return 0;
 	}
@@ -4236,5 +4236,5 @@ rte_eth_tx_prepare(uint16_t port_id, uint16_t queue_id,
 	if (queue_id >= dev->data->nb_tx_queues) {
 		RTE_ETHDEV_LOG(ERR, "Invalid TX queue_id=%u\n", queue_id);
-		rte_errno = -EINVAL;
+		rte_errno = EINVAL;
 		return 0;
 	}
-- 
2.19.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-02-07 13:19:56.571671032 +0000
+++ 0044-ethdev-fix-errno-to-have-positive-value.patch	2019-02-07 13:19:55.000000000 +0000
@@ -1,14 +1,15 @@
-From 8e0c8dcf3507ae812f1abcd5247617917f131dae Mon Sep 17 00:00:00 2001
+From 9d0084878cf266f5c083ef5a4d6276840e2c7ba5 Mon Sep 17 00:00:00 2001
 From: Andrew Rybchenko <arybchenko at solarflare.com>
 Date: Mon, 21 Jan 2019 16:18:35 +0000
 Subject: [PATCH] ethdev: fix errno to have positive value
 
+[ upstream commit 8e0c8dcf3507ae812f1abcd5247617917f131dae ]
+
 rte_errno should be set to positive value from errno.h plus
 few RTE-specific values.
 
 Fixes: 4fb7e803eb1a ("ethdev: add Tx preparation")
 Fixes: 439a90b5f2a7 ("ethdev: reorder inline functions")
-Cc: stable at dpdk.org
 
 Signed-off-by: Andrew Rybchenko <arybchenko at solarflare.com>
 ---
@@ -16,17 +17,17 @@
  1 file changed, 2 insertions(+), 2 deletions(-)
 
 diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h
-index 76266ad10..a3c864a13 100644
+index 1960f3a2d..a3e9fb816 100644
 --- a/lib/librte_ethdev/rte_ethdev.h
 +++ b/lib/librte_ethdev/rte_ethdev.h
-@@ -4223,5 +4223,5 @@ rte_eth_tx_prepare(uint16_t port_id, uint16_t queue_id,
+@@ -4226,5 +4226,5 @@ rte_eth_tx_prepare(uint16_t port_id, uint16_t queue_id,
  	if (!rte_eth_dev_is_valid_port(port_id)) {
  		RTE_ETHDEV_LOG(ERR, "Invalid TX port_id=%u\n", port_id);
 -		rte_errno = -EINVAL;
 +		rte_errno = EINVAL;
  		return 0;
  	}
-@@ -4233,5 +4233,5 @@ rte_eth_tx_prepare(uint16_t port_id, uint16_t queue_id,
+@@ -4236,5 +4236,5 @@ rte_eth_tx_prepare(uint16_t port_id, uint16_t queue_id,
  	if (queue_id >= dev->data->nb_tx_queues) {
  		RTE_ETHDEV_LOG(ERR, "Invalid TX queue_id=%u\n", queue_id);
 -		rte_errno = -EINVAL;


More information about the stable mailing list