[dpdk-stable] patch 'app/testpmd: fix Tx metadata show command' has been queued to LTS release 18.11.1
Kevin Traynor
ktraynor at redhat.com
Thu Feb 7 14:26:01 CET 2019
Hi,
FYI, your patch has been queued to LTS release 18.11.1
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/14/19. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Thanks.
Kevin Traynor
---
>From 3830f48513ff1568b81f9b3d694444e0766c8b4f Mon Sep 17 00:00:00 2001
From: Dekel Peled <dekelp at mellanox.com>
Date: Tue, 22 Jan 2019 17:16:43 +0200
Subject: [PATCH] app/testpmd: fix Tx metadata show command
[ upstream commit 5ffbd70b1712d1856aa86f18877628b2d94813ce ]
Function cmd_config_tx_metadata_specific_parsed() takes input value,
applies rte_cpu_to_be_32() on it, and stores it for Tx use.
Function cmd_show_tx_metadata_parsed() displays the stored value as is.
This patch modifies function cmd_show_tx_metadata_parsed(), to apply
rte_be_to_cpu_32() on the stored value before displaying it.
Fixes: c18feafa193c ("app/testpmd: support metadata as flow rule item")
Signed-off-by: Dekel Peled <dekelp at mellanox.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit at intel.com>
---
app/test-pmd/cmdline.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 3ddc3e02a..51704b500 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -18456,5 +18456,5 @@ cmd_show_tx_metadata_parsed(void *parsed_result,
if (!strcmp(res->cmd_keyword, "tx_metadata")) {
printf("Port %u tx_metadata: %u\n", res->cmd_pid,
- ports[res->cmd_pid].tx_metadata);
+ rte_be_to_cpu_32(ports[res->cmd_pid].tx_metadata));
}
}
--
2.19.0
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2019-02-07 13:19:56.855713177 +0000
+++ 0055-app-testpmd-fix-Tx-metadata-show-command.patch 2019-02-07 13:19:55.000000000 +0000
@@ -1,8 +1,10 @@
-From 5ffbd70b1712d1856aa86f18877628b2d94813ce Mon Sep 17 00:00:00 2001
+From 3830f48513ff1568b81f9b3d694444e0766c8b4f Mon Sep 17 00:00:00 2001
From: Dekel Peled <dekelp at mellanox.com>
Date: Tue, 22 Jan 2019 17:16:43 +0200
Subject: [PATCH] app/testpmd: fix Tx metadata show command
+[ upstream commit 5ffbd70b1712d1856aa86f18877628b2d94813ce ]
+
Function cmd_config_tx_metadata_specific_parsed() takes input value,
applies rte_cpu_to_be_32() on it, and stores it for Tx use.
Function cmd_show_tx_metadata_parsed() displays the stored value as is.
@@ -11,7 +13,6 @@
rte_be_to_cpu_32() on the stored value before displaying it.
Fixes: c18feafa193c ("app/testpmd: support metadata as flow rule item")
-Cc: stable at dpdk.org
Signed-off-by: Dekel Peled <dekelp at mellanox.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit at intel.com>
More information about the stable
mailing list