[dpdk-stable] patch 'net/ena: skip packet with wrong request id' has been queued to LTS release 18.11.1

Kevin Traynor ktraynor at redhat.com
Fri Jan 4 14:24:33 CET 2019


Hi,

FYI, your patch has been queued to LTS release 18.11.1

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 01/11/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Kevin Traynor

---
>From 5c54c8b11262543258e8c05ba91e358c5b2db197 Mon Sep 17 00:00:00 2001
From: Rafal Kozik <rk at semihalf.com>
Date: Fri, 14 Dec 2018 14:18:31 +0100
Subject: [PATCH] net/ena: skip packet with wrong request id

[ upstream commit f00930d929151fc09914e6d61b827f9f81645324 ]

When invalid req_id is received, the reset should be handled by the
application, as it is indicating invalid rings state, so further Rx
is not making any sense.

Fixes: c2034976673d ("net/ena: add Rx out of order completion")

Signed-off-by: Rafal Kozik <rk at semihalf.com>
Acked-by: Michal Krawczyk <mk at semihalf.com>
---
 drivers/net/ena/ena_ethdev.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c
index 76e8d499d..e7b462859 100644
--- a/drivers/net/ena/ena_ethdev.c
+++ b/drivers/net/ena/ena_ethdev.c
@@ -1947,4 +1947,6 @@ static uint16_t eth_ena_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,
 			next_to_clean++;
 		}
+		if (unlikely(rc))
+			break;
 
 		/* fill mbuf attributes if any */
-- 
2.19.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-01-04 13:23:08.686581421 +0000
+++ 0051-net-ena-skip-packet-with-wrong-request-id.patch	2019-01-04 13:23:07.000000000 +0000
@@ -1,14 +1,15 @@
-From f00930d929151fc09914e6d61b827f9f81645324 Mon Sep 17 00:00:00 2001
+From 5c54c8b11262543258e8c05ba91e358c5b2db197 Mon Sep 17 00:00:00 2001
 From: Rafal Kozik <rk at semihalf.com>
 Date: Fri, 14 Dec 2018 14:18:31 +0100
 Subject: [PATCH] net/ena: skip packet with wrong request id
 
+[ upstream commit f00930d929151fc09914e6d61b827f9f81645324 ]
+
 When invalid req_id is received, the reset should be handled by the
 application, as it is indicating invalid rings state, so further Rx
 is not making any sense.
 
 Fixes: c2034976673d ("net/ena: add Rx out of order completion")
-Cc: stable at dpdk.org
 
 Signed-off-by: Rafal Kozik <rk at semihalf.com>
 Acked-by: Michal Krawczyk <mk at semihalf.com>
@@ -17,10 +18,10 @@
  1 file changed, 2 insertions(+)
 
 diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c
-index 617f85f02..505d9bf30 100644
+index 76e8d499d..e7b462859 100644
 --- a/drivers/net/ena/ena_ethdev.c
 +++ b/drivers/net/ena/ena_ethdev.c
-@@ -1989,4 +1989,6 @@ static uint16_t eth_ena_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,
+@@ -1947,4 +1947,6 @@ static uint16_t eth_ena_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,
  			next_to_clean++;
  		}
 +		if (unlikely(rc))


More information about the stable mailing list