[dpdk-stable] patch 'test/crypto: fix misleading trace message' has been queued to LTS release 18.11.1

[Kevin Traynor]

Hi,

FYI, your patch has been queued to LTS release 18.11.1

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/07/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Kevin Traynor

---
>From 531c084eefe7fb8c5dff6f9439e1e4190d8c9cf7 Mon Sep 17 00:00:00 2001
From: Fiona Trahe <fiona.trahe at intel.com>
Date: Fri, 21 Dec 2018 00:01:25 +0000
Subject: [PATCH] test/crypto: fix misleading trace message

[ upstream commit 1113ba1dcb7e78a8a839c294523e1939d14aae98 ]

Test was reporting digest verification failed for all operation errors.
Fixed so it only reports this if the PMD actually reports an auth failure.

Fixes: 9c0eed2f06ae ("app/test: rework crypto AES unit test")

Signed-off-by: Fiona Trahe <fiona.trahe at intel.com>
Acked-by: Pablo de Lara <pablo.de.lara.guarch at intel.com>
---
 test/test/test_cryptodev_blockcipher.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/test/test/test_cryptodev_blockcipher.c b/test/test/test_cryptodev_blockcipher.c
index 1c3f29f6b..4f1298ea2 100644
--- a/test/test/test_cryptodev_blockcipher.c
+++ b/test/test/test_cryptodev_blockcipher.c
@@ -402,5 +402,6 @@ test_blockcipher_one_case(const struct blockcipher_test_case *t,
 	/* Verify results */
 	if (op->status != RTE_CRYPTO_OP_STATUS_SUCCESS) {
-		if (t->op_mask & BLOCKCIPHER_TEST_OP_AUTH_VERIFY)
+		if ((t->op_mask & BLOCKCIPHER_TEST_OP_AUTH_VERIFY) &&
+			(op->status == RTE_CRYPTO_OP_STATUS_AUTH_FAILED))
 			snprintf(test_msg, BLOCKCIPHER_TEST_MSG_LEN, "line %u "
 				"FAILED: Digest verification failed "
@@ -408,5 +409,5 @@ test_blockcipher_one_case(const struct blockcipher_test_case *t,
 		else
 			snprintf(test_msg, BLOCKCIPHER_TEST_MSG_LEN, "line %u "
-				"FAILED: Digest verification failed "
+				"FAILED: Operation failed "
 				"(0x%X)", __LINE__, op->status);
 		status = TEST_FAILED;
-- 
2.19.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-01-31 15:44:05.891018381 +0000
+++ 0006-test-crypto-fix-misleading-trace-message.patch	2019-01-31 15:44:05.000000000 +0000
@@ -1,13 +1,14 @@
-From 1113ba1dcb7e78a8a839c294523e1939d14aae98 Mon Sep 17 00:00:00 2001
+From 531c084eefe7fb8c5dff6f9439e1e4190d8c9cf7 Mon Sep 17 00:00:00 2001
 From: Fiona Trahe <fiona.trahe at intel.com>
 Date: Fri, 21 Dec 2018 00:01:25 +0000
 Subject: [PATCH] test/crypto: fix misleading trace message
 
+[ upstream commit 1113ba1dcb7e78a8a839c294523e1939d14aae98 ]
+
 Test was reporting digest verification failed for all operation errors.
 Fixed so it only reports this if the PMD actually reports an auth failure.
 
 Fixes: 9c0eed2f06ae ("app/test: rework crypto AES unit test")
-Cc: stable at dpdk.org
 
 Signed-off-by: Fiona Trahe <fiona.trahe at intel.com>
 Acked-by: Pablo de Lara <pablo.de.lara.guarch at intel.com>