[dpdk-stable] patch 'net/tap: allow full length names' has been queued to LTS release 18.11.1

[Kevin Traynor]

Hi,

FYI, your patch has been queued to LTS release 18.11.1

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/07/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Kevin Traynor

---
>From 22c87d3f946e3addf0dec7c553347198b02362df Mon Sep 17 00:00:00 2001
From: Stephen Hemminger <stephen at networkplumber.org>
Date: Fri, 11 Jan 2019 12:35:15 -0800
Subject: [PATCH] net/tap: allow full length names

[ upstream commit 12ad0b6572d0793d0dc100b32caec5a2859399ed ]

The code for set_interface_name was incorrectly assuming that
space for null byte was necessary with snprintf/strlcpy.

Fixes: 02f96a0a82d1 ("net/tap: add TUN/TAP device PMD")

Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
Acked-by Keith Wiles <keith.wiles at intel.com>
---
 drivers/net/tap/rte_eth_tap.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index 0ec030bef..aef8b0b9f 100644
--- a/drivers/net/tap/rte_eth_tap.c
+++ b/drivers/net/tap/rte_eth_tap.c
@@ -1893,8 +1893,8 @@ set_interface_name(const char *key __rte_unused,
 
 	if (value)
-		strlcpy(name, value, RTE_ETH_NAME_MAX_LEN - 1);
+		strlcpy(name, value, RTE_ETH_NAME_MAX_LEN);
 	else
-		snprintf(name, RTE_ETH_NAME_MAX_LEN - 1, "%s%d",
-			 DEFAULT_TAP_NAME, (tap_unit - 1));
+		snprintf(name, RTE_ETH_NAME_MAX_LEN, "%s%d",
+			 DEFAULT_TAP_NAME, tap_unit - 1);
 
 	return 0;
-- 
2.19.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-01-31 15:44:06.924515000 +0000
+++ 0051-net-tap-allow-full-length-names.patch	2019-01-31 15:44:05.000000000 +0000
@@ -1,13 +1,14 @@
-From 12ad0b6572d0793d0dc100b32caec5a2859399ed Mon Sep 17 00:00:00 2001
+From 22c87d3f946e3addf0dec7c553347198b02362df Mon Sep 17 00:00:00 2001
 From: Stephen Hemminger <stephen at networkplumber.org>
 Date: Fri, 11 Jan 2019 12:35:15 -0800
 Subject: [PATCH] net/tap: allow full length names
 
+[ upstream commit 12ad0b6572d0793d0dc100b32caec5a2859399ed ]
+
 The code for set_interface_name was incorrectly assuming that
 space for null byte was necessary with snprintf/strlcpy.
 
 Fixes: 02f96a0a82d1 ("net/tap: add TUN/TAP device PMD")
-Cc: stable at dpdk.org
 
 Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
 Acked-by Keith Wiles <keith.wiles at intel.com>
@@ -16,7 +17,7 @@
  1 file changed, 3 insertions(+), 3 deletions(-)
 
 diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
-index 1c00681ba..11e402e42 100644
+index 0ec030bef..aef8b0b9f 100644
 --- a/drivers/net/tap/rte_eth_tap.c
 +++ b/drivers/net/tap/rte_eth_tap.c
 @@ -1893,8 +1893,8 @@ set_interface_name(const char *key __rte_unused,