[dpdk-stable] patch 'power: fix frequency list buffer validation' has been queued to LTS release 17.11.7

Yongseok Koh yskoh at mellanox.com
Tue Jul 23 03:00:18 CEST 2019


Hi,

FYI, your patch has been queued to LTS release 17.11.7

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objection by 07/27/19. So please
shout if anyone has objection.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Yongseok

---
>From 94fa1bf6191c3ba3bbeb7025493a737068621674 Mon Sep 17 00:00:00 2001
From: Kevin Traynor <ktraynor at redhat.com>
Date: Wed, 6 Feb 2019 12:19:06 +0000
Subject: [PATCH] power: fix frequency list buffer validation

[ upstream commit e1e4dafbc7b83c695eb745fe033f5c1e9e344454 ]

The frequency list buffer was already validated in
power_acpi_cpufreq_freqs(), so the newly added check was redundant.
To keep consistency with power_pstate_cpufreq_freqs(), remove the
original check and update the log message.

Fixes: 2e6ccdb4e088 ("power: fix frequency list to handle null buffer")

Signed-off-by: Kevin Traynor <ktraynor at redhat.com>
---
 lib/librte_power/rte_power_acpi_cpufreq.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/librte_power/rte_power_acpi_cpufreq.c b/lib/librte_power/rte_power_acpi_cpufreq.c
index 6b0cdb2eb4..9a2fa81d28 100644
--- a/lib/librte_power/rte_power_acpi_cpufreq.c
+++ b/lib/librte_power/rte_power_acpi_cpufreq.c
@@ -465,8 +465,8 @@ rte_power_acpi_cpufreq_freqs(unsigned lcore_id, uint32_t *freqs, uint32_t num)
 {
 	struct rte_power_info *pi;
 
-	if (lcore_id >= RTE_MAX_LCORE || !freqs) {
-		RTE_LOG(ERR, POWER, "Invalid input parameter\n");
+	if (lcore_id >= RTE_MAX_LCORE) {
+		RTE_LOG(ERR, POWER, "Invalid lcore ID\n");
 		return 0;
 	}
 
-- 
2.21.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-07-22 17:55:09.261363083 -0700
+++ 0051-power-fix-frequency-list-buffer-validation.patch	2019-07-22 17:55:06.118471000 -0700
@@ -1,26 +1,27 @@
-From e1e4dafbc7b83c695eb745fe033f5c1e9e344454 Mon Sep 17 00:00:00 2001
+From 94fa1bf6191c3ba3bbeb7025493a737068621674 Mon Sep 17 00:00:00 2001
 From: Kevin Traynor <ktraynor at redhat.com>
 Date: Wed, 6 Feb 2019 12:19:06 +0000
 Subject: [PATCH] power: fix frequency list buffer validation
 
+[ upstream commit e1e4dafbc7b83c695eb745fe033f5c1e9e344454 ]
+
 The frequency list buffer was already validated in
 power_acpi_cpufreq_freqs(), so the newly added check was redundant.
 To keep consistency with power_pstate_cpufreq_freqs(), remove the
 original check and update the log message.
 
 Fixes: 2e6ccdb4e088 ("power: fix frequency list to handle null buffer")
-Cc: stable at dpdk.org
 
 Signed-off-by: Kevin Traynor <ktraynor at redhat.com>
 ---
- lib/librte_power/power_acpi_cpufreq.c | 4 ++--
+ lib/librte_power/rte_power_acpi_cpufreq.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
 
-diff --git a/lib/librte_power/power_acpi_cpufreq.c b/lib/librte_power/power_acpi_cpufreq.c
-index 45412f0b99..534efe817d 100644
---- a/lib/librte_power/power_acpi_cpufreq.c
-+++ b/lib/librte_power/power_acpi_cpufreq.c
-@@ -440,8 +440,8 @@ power_acpi_cpufreq_freqs(unsigned int lcore_id, uint32_t *freqs, uint32_t num)
+diff --git a/lib/librte_power/rte_power_acpi_cpufreq.c b/lib/librte_power/rte_power_acpi_cpufreq.c
+index 6b0cdb2eb4..9a2fa81d28 100644
+--- a/lib/librte_power/rte_power_acpi_cpufreq.c
++++ b/lib/librte_power/rte_power_acpi_cpufreq.c
+@@ -465,8 +465,8 @@ rte_power_acpi_cpufreq_freqs(unsigned lcore_id, uint32_t *freqs, uint32_t num)
  {
  	struct rte_power_info *pi;
  


More information about the stable mailing list