[dpdk-stable] patch 'net/ixgbe: fix unexpected link handler' has been queued to LTS release 18.11.3
Kevin Traynor
ktraynor at redhat.com
Fri Jun 21 18:45:47 CEST 2019
Hi,
FYI, your patch has been queued to LTS release 18.11.3
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 06/26/19. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue
This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/f19610f8d2b667b5dacd14fc619b986cb2b32a31
Thanks.
Kevin Traynor
---
>From f19610f8d2b667b5dacd14fc619b986cb2b32a31 Mon Sep 17 00:00:00 2001
From: Yunjian Wang <wangyunjian at huawei.com>
Date: Wed, 8 May 2019 20:51:38 +0800
Subject: [PATCH] net/ixgbe: fix unexpected link handler
[ upstream commit 03bb633aa86232df29a0692b2727cff3e4e1b685 ]
The nic's interrupt source has some active handler, which maybe call
ixgbe_dev_link_update() to set link handler. We should cancel the
link handler before remove dev to prevent executing the link handler.
It triggers segfault.
Fixes: 0408f47ba4d6 ("net/ixgbe: fix busy polling while fiber link update")
Signed-off-by: Yunjian Wang <wangyunjian at huawei.com>
Acked-by: Wei Zhao <wei.zhao1 at intel.com>
---
drivers/net/ixgbe/ixgbe_ethdev.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index e9533e5a1..6341c1a3e 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -1340,4 +1340,7 @@ eth_ixgbe_dev_uninit(struct rte_eth_dev *eth_dev)
rte_eal_alarm_cancel(ixgbe_dev_interrupt_delayed_handler, eth_dev);
+ /* cancel the link handler before remove dev */
+ rte_eal_alarm_cancel(ixgbe_dev_setup_link_alarm_handler, eth_dev);
+
/* uninitialize PF if max_vfs not zero */
ixgbe_pf_host_uninit(eth_dev);
--
2.20.1
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2019-06-21 17:22:11.901814697 +0100
+++ 0003-net-ixgbe-fix-unexpected-link-handler.patch 2019-06-21 17:22:11.704519558 +0100
@@ -1 +1 @@
-From 03bb633aa86232df29a0692b2727cff3e4e1b685 Mon Sep 17 00:00:00 2001
+From f19610f8d2b667b5dacd14fc619b986cb2b32a31 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 03bb633aa86232df29a0692b2727cff3e4e1b685 ]
+
@@ -12 +13,0 @@
-Cc: stable at dpdk.org
@@ -21 +22 @@
-index 975fa474c..2470c89cf 100644
+index e9533e5a1..6341c1a3e 100644
@@ -24 +25 @@
-@@ -1345,4 +1345,7 @@ eth_ixgbe_dev_uninit(struct rte_eth_dev *eth_dev)
+@@ -1340,4 +1340,7 @@ eth_ixgbe_dev_uninit(struct rte_eth_dev *eth_dev)
More information about the stable
mailing list