[dpdk-stable] patch 'net/bonding: remove unnecessary cast' has been queued to LTS release 18.11.3
Kevin Traynor
ktraynor at redhat.com
Mon Jun 24 17:24:29 CEST 2019
Hi,
FYI, your patch has been queued to LTS release 18.11.3
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 06/27/19. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue
This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/d946ec272036f94ddd182aaeb852463dbd61d2cc
Thanks.
Kevin Traynor
---
>From d946ec272036f94ddd182aaeb852463dbd61d2cc Mon Sep 17 00:00:00 2001
From: Stephen Hemminger <stephen at networkplumber.org>
Date: Wed, 29 May 2019 12:14:54 -0700
Subject: [PATCH] net/bonding: remove unnecessary cast
[ upstream commit 0b07f6e992a29fa994d3281d80a74b0e10b181ef ]
The device private pointer (dev_private) is of type void *
therefore no cast is necessary in C.
Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
Reviewed-by: Ferruh Yigit <ferruh.yigit at intel.com>
---
drivers/net/bonding/rte_eth_bond_pmd.c | 20 +++++++-------------
1 file changed, 7 insertions(+), 13 deletions(-)
diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c
index 154257ffe..64518200e 100644
--- a/drivers/net/bonding/rte_eth_bond_pmd.c
+++ b/drivers/net/bonding/rte_eth_bond_pmd.c
@@ -159,6 +159,5 @@ bond_ethdev_8023ad_flow_verify(struct rte_eth_dev *bond_dev,
struct rte_eth_dev_info slave_info;
struct rte_flow_error error;
- struct bond_dev_private *internals = (struct bond_dev_private *)
- (bond_dev->data->dev_private);
+ struct bond_dev_private *internals = bond_dev->data->dev_private;
const struct rte_flow_action_queue lacp_queue_conf = {
@@ -200,6 +199,5 @@ int
bond_8023ad_slow_pkt_hw_filter_supported(uint16_t port_id) {
struct rte_eth_dev *bond_dev = &rte_eth_devices[port_id];
- struct bond_dev_private *internals = (struct bond_dev_private *)
- (bond_dev->data->dev_private);
+ struct bond_dev_private *internals = bond_dev->data->dev_private;
struct rte_eth_dev_info bond_info;
uint16_t idx;
@@ -226,7 +224,5 @@ bond_ethdev_8023ad_flow_set(struct rte_eth_dev *bond_dev, uint16_t slave_port) {
struct rte_flow_error error;
- struct bond_dev_private *internals = (struct bond_dev_private *)
- (bond_dev->data->dev_private);
-
+ struct bond_dev_private *internals = bond_dev->data->dev_private;
struct rte_flow_action_queue lacp_queue_conf = {
.index = internals->mode4.dedicated_queues.rx_qid,
@@ -1718,6 +1714,5 @@ slave_configure_slow_queue(struct rte_eth_dev *bonded_eth_dev,
{
int errval = 0;
- struct bond_dev_private *internals = (struct bond_dev_private *)
- bonded_eth_dev->data->dev_private;
+ struct bond_dev_private *internals = bonded_eth_dev->data->dev_private;
struct port *port = &bond_mode_8023ad_ports[slave_eth_dev->data->port_id];
@@ -1785,6 +1780,5 @@ slave_configure(struct rte_eth_dev *bonded_eth_dev,
struct rte_flow_error flow_error;
- struct bond_dev_private *internals = (struct bond_dev_private *)
- bonded_eth_dev->data->dev_private;
+ struct bond_dev_private *internals = bonded_eth_dev->data->dev_private;
/* Stop slave */
@@ -2404,6 +2398,6 @@ bond_ethdev_slave_link_status_change_monitor(void *cb_arg)
return;
- bonded_ethdev = (struct rte_eth_dev *)cb_arg;
- internals = (struct bond_dev_private *)bonded_ethdev->data->dev_private;
+ bonded_ethdev = cb_arg;
+ internals = bonded_ethdev->data->dev_private;
if (!bonded_ethdev->data->dev_started ||
--
2.20.1
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2019-06-24 16:18:55.358272483 +0100
+++ 0005-net-bonding-remove-unnecessary-cast.patch 2019-06-24 16:18:54.940433371 +0100
@@ -1 +1 @@
-From 0b07f6e992a29fa994d3281d80a74b0e10b181ef Mon Sep 17 00:00:00 2001
+From d946ec272036f94ddd182aaeb852463dbd61d2cc Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 0b07f6e992a29fa994d3281d80a74b0e10b181ef ]
+
@@ -9,2 +10,0 @@
-Cc: stable at dpdk.org
-
@@ -18 +18 @@
-index ca3494552..6a6ed890a 100644
+index 154257ffe..64518200e 100644
@@ -21 +21 @@
-@@ -161,6 +161,5 @@ bond_ethdev_8023ad_flow_verify(struct rte_eth_dev *bond_dev,
+@@ -159,6 +159,5 @@ bond_ethdev_8023ad_flow_verify(struct rte_eth_dev *bond_dev,
@@ -29 +29 @@
-@@ -202,6 +201,5 @@ int
+@@ -200,6 +199,5 @@ int
@@ -37 +37 @@
-@@ -228,7 +226,5 @@ bond_ethdev_8023ad_flow_set(struct rte_eth_dev *bond_dev, uint16_t slave_port) {
+@@ -226,7 +224,5 @@ bond_ethdev_8023ad_flow_set(struct rte_eth_dev *bond_dev, uint16_t slave_port) {
@@ -46 +46 @@
-@@ -1736,6 +1732,5 @@ slave_configure_slow_queue(struct rte_eth_dev *bonded_eth_dev,
+@@ -1718,6 +1714,5 @@ slave_configure_slow_queue(struct rte_eth_dev *bonded_eth_dev,
@@ -54 +54 @@
-@@ -1803,6 +1798,5 @@ slave_configure(struct rte_eth_dev *bonded_eth_dev,
+@@ -1785,6 +1780,5 @@ slave_configure(struct rte_eth_dev *bonded_eth_dev,
@@ -62 +62 @@
-@@ -2422,6 +2416,6 @@ bond_ethdev_slave_link_status_change_monitor(void *cb_arg)
+@@ -2404,6 +2398,6 @@ bond_ethdev_slave_link_status_change_monitor(void *cb_arg)
More information about the stable
mailing list